682294 - Opening a page which we can't read should display an error page

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Brian R. Bondy [:bbondy]]

Reproduced on Windows XP, Windows 7, and Ubuntu.

Steps to Reproduce:
1. Create an .html file on your C:\ or a UNC path.
2. Remove read permissions from the file.
3. Try to load the file:// in Firefox.

Actual Results:  
Opens a blank Mozilla page with no data.

Expected Results:  
Some kind of an error page should be displayed.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Is this the usual issue with nsFileChannel::AsyncOpen throwing?

Comment 2

[Brian R. Bondy [:bbondy]]

I haven't looked at where the error is in code yet, but I'm posting based on Bug 263816.

You had mentioned in that bug:

> networking in Mozilla handles all interaction between the
layout engine and the outside world, INCLUDING local file access.  The local
file case sounds like networking is not returning the right errors to the layout
code.

Comment 3

[Boris Zbarsky [:bzbarsky]]

OK.  Worth checking whether we end up with an exception from AsyncOpen or just an unknown error code in nsDocShell::EndPageLoad.

Comment 4

[Dragana Damjanovic [:dragana]]

nsDocShell gets a error code NS_ERROR_FILE_ACCESS_DENIED (0x80520015) bt does not display an error code for it.
This is docShell bug

Comment 5

[Boris Zbarsky [:bzbarsky]]

> nsDocShell gets a error code NS_ERROR_FILE_ACCESS_DENIED (0x80520015)

Via EndPageLoad or AsyncOpen throwing?

> bt does not display an error code for it.

You mean doesn't display an error page?

Comment 6

[Dragana Damjanovic [:dragana]]

(In reply to Boris Zbarsky [:bz] from comment #5)
> > nsDocShell gets a error code NS_ERROR_FILE_ACCESS_DENIED (0x80520015)
> 
> Via EndPageLoad or AsyncOpen throwing?
> 

EndPageLoad is called

> > bt does not display an error code for it.
> 
> You mean doesn't display an error page?

Sorry, it doesn't display an error page.

Comment 8

[John Dai[:jdai]]

Attachment: Bug 682294 - Add an error page for file access denied. v1

I've verified that the error page shows up fine.
Hi Boris, may I have your review? Thank you.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8738498 [details] [diff] [review]
Bug 682294 - Add an error page for file access denied. v1

r=me, but it would be nice in the future to not mix whitespace cleanup in with substantive changes...

Comment 10

[John Dai[:jdai]]

(In reply to Boris Zbarsky [:bz] from comment #9)
> Comment on attachment 8738498 [details] [diff] [review]
> Bug 682294 - Add an error page for file access denied. v1
> 
> r=me, but it would be nice in the future to not mix whitespace cleanup in
> with substantive changes...

Sorry, it's my fault. I would like to separate whitespace cleanup to another patch and send a review again. Thank you for reviewing my patch.

Comment 11

[John Dai[:jdai]]

Attachment: Part 1: Bug 682294 - Add an error page for file access denied. (Final) r=bz

Comment 12

[John Dai[:jdai]]

Attachment: Part 2: Bug 682294 - Remove redundent trailing spaces.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8738581 [details] [diff] [review]
Part 1: Bug 682294 - Add an error page for file access denied. (Final) r=bz

r=me; it really was ok to just split up the existing reviewed patch without asking for more review... ;)

Comment 14

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8738582 [details] [diff] [review]
Part 2: Bug 682294 - Remove redundent trailing spaces.

"redundant", in the commit message.

Comment 15

[John Dai[:jdai]]

Attachment: Part 2: Bug 682294 - Remove redundant trailing spaces. (Final) r=bz

Comment 16

[John Dai[:jdai]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bcf2789d76f0

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b486146cd3fb
https://hg.mozilla.org/integration/mozilla-inbound/rev/16fab0a75b35

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b486146cd3fb
https://hg.mozilla.org/mozilla-central/rev/16fab0a75b35