Last Comment Bug 682536 - Showing/hiding the conditional forward button shouldn't resize the search bar
: Showing/hiding the conditional forward button shouldn't resize the search bar
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All Linux
: -- normal with 1 vote (vote)
: Firefox 10
Assigned To: Dão Gottwald [:dao]
:
Mentors:
Depends on: 682534
Blocks: 677027
  Show dependency treegraph
 
Reported: 2011-08-27 02:48 PDT by Dão Gottwald [:dao]
Modified: 2013-11-12 00:56 PST (History)
8 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (3.84 KB, patch)
2011-10-17 07:56 PDT, Dão Gottwald [:dao]
shorlander: review+
Details | Diff | Review

Description Dão Gottwald [:dao] 2011-08-27 02:48:36 PDT

    
Comment 1 Mardeg 2011-08-27 04:17:40 PDT
People on IRC are already asking for a way to disable conditional forward button on nightly builds of linux since it landed there on bug 677027, likely due to more use-cases than just the searchbar.
For example, the case of people taking advantage of the great Firefox strength in customisability of moving many UI items onto the same bar as the back/forward button, would this detect and prevent such customised UI elements from jumping? I don't want to see this blowing up into more negative tech press.
Comment 2 Pascal Chevrel:pascalc 2011-09-06 12:37:15 PDT
This is indeed an annoying side effect, plus the sliding is jerky for me.
screencast on today's build:
http://video.chevrel.org/out.ogv

I don't think UI elements should move without a good reason (like tab reordering), this is very visually distracting.
Comment 3 Jared Wein [:jaws] (please needinfo? me) 2011-10-11 22:14:30 PDT
This is happening now on Nightly-Windows (10/11/2011) with a clean profile.
Comment 4 Dão Gottwald [:dao] 2011-10-11 23:43:56 PDT
(In reply to Jared Wein [:jwein] from comment #3)
> This is happening now on Nightly-Windows (10/11/2011) with a clean profile.

Please file a new bug.
Comment 5 Dão Gottwald [:dao] 2011-10-12 11:33:50 PDT
(In reply to Dão Gottwald [:dao] from comment #4)
> (In reply to Jared Wein [:jwein] from comment #3)
> > This is happening now on Nightly-Windows (10/11/2011) with a clean profile.
> 
> Please file a new bug.

I filed bug 694084.
Comment 6 Dão Gottwald [:dao] 2011-10-17 07:56:41 PDT
Created attachment 567445 [details] [diff] [review]
patch
Comment 7 Stephen Horlander [:shorlander] 2011-10-31 14:32:21 PDT
Comment on attachment 567445 [details] [diff] [review]
patch

With a fresh profile this still resizes the search bar until you manually resize the urlbar/searchbar splitter. I noticed the same thing on the Windows and OSX versions.

Is there any way around that?
Comment 8 Dão Gottwald [:dao] 2011-11-01 01:52:58 PDT
(In reply to Stephen Horlander from comment #7)
That's expected as far as this patch is concerned. Bug 694084 covers the rest.
Comment 9 Stephen Horlander [:shorlander] 2011-11-01 11:14:10 PDT
(In reply to Dão Gottwald [:dao] from comment #8)
> (In reply to Stephen Horlander from comment #7)
> That's expected as far as this patch is concerned. Bug 694084 covers the
> rest.

Awesome, thank you!
Comment 11 Ed Morley [:emorley] 2011-11-02 06:34:39 PDT
https://hg.mozilla.org/mozilla-central/rev/8d6bdc1a656f

Note You need to log in before you can comment on or make changes to this bug.