Last Comment Bug 682539 - Add nsTreeColumn::mNext to CC
: Add nsTreeColumn::mNext to CC
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Peter Van der Beken [:peterv]
:
Mentors:
Depends on:
Blocks: 637099
  Show dependency treegraph
 
Reported: 2011-08-27 03:04 PDT by Peter Van der Beken [:peterv]
Modified: 2011-08-28 13:29 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (3.05 KB, patch)
2011-08-27 03:04 PDT, Peter Van der Beken [:peterv]
bugs: review+
Details | Diff | Review

Description Peter Van der Beken [:peterv] 2011-08-27 03:04:37 PDT
Created attachment 556246 [details] [diff] [review]
v1

nsTreeColumn is a cycle collected class and it's in a linked list, pretty obvious it needs to traverse to the next in the list.
Comment 1 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2011-08-27 05:11:44 PDT
Comment on attachment 556246 [details] [diff] [review]
v1

Ah, sorry, I missed this in Bug 461640.
Comment 2 Andrew McCreight (PTO-ish through 6-29) [:mccr8] 2011-08-27 05:42:38 PDT
Oh, that's tricky.  I don't have an analysis that will even try to find raw pointer fields that should be ref counted.
Comment 3 Ed Morley [:emorley] 2011-08-28 13:28:54 PDT
http://hg.mozilla.org/mozilla-central/rev/7c905a200bcc

Note You need to log in before you can comment on or make changes to this bug.