Closed
Bug 682560
Opened 14 years ago
Closed 14 years ago
Global variable leak
Categories
(Tree Management Graveyard :: TBPL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Swatinem, Assigned: Swatinem)
Details
Attachments
(1 file)
|
856 bytes,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
These use var like they should, but the code is run in the global scope so they leak anyway.
This just moves them to an anonymous closure.
Attachment #556258 -
Flags: review?(mstange)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 556258 [details] [diff] [review]
fix
So only two strings? OK, as long as it makes leak statistics easier to read...
Attachment #556258 -
Flags: review?(mstange) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
yes, I’m always suspicious of oddly named vars in firebugs dom tab.
pushed: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/2b20606b6ea3
|
||
Comment 3•14 years ago
|
||
Deployed via bug 683241
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: Webtools → Tree Management
|
|
||
Updated•10 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•