682725 - POP function does not regenerate missing .msf files

Status: UNCONFIRMED

(Thunderbird :: Folder and Message Lists, defect)

Description

[william.allen.simpson]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0) Gecko/20100101 Firefox/6.0
Build ID: 20110811165603

Steps to reproduce:

TB 3.1.12

After TB 6.0 zeroed all my .msf (see bug 682588), downgraded to 3.1.12, and hand removed them (see bug 682721). POP new mail, including these bug reports.


Actual results:

The POP message filter correctly moved the bug reports into the m-bugs.all folder, but the list did not show any messages. The .msf was not regenerated.


Expected results:

The .msf should be regenerated. The list pane should highlight, and the unseen message count (in parenthesis) should show the new messages.

Comment 1

[william.allen.simpson]

Attachment: mozilla folder before POP

Here is the state of the folder before POP. The zero length .sbd mail files have a 4K .msf from the first restart (12:34 pm), but no others (bug 682721). The .sbd folders were updated on a subsequent restart (12:49 pm), but nothing else was updated by the test search.

Note the latest message in m-bugs.all is Aug 25.

Comment 2

[william.allen.simpson]

Attachment: list view before POP

Here is the state of the list view before POP.

Note that m-bugs.all has no unseen messages (in parenthesis).

Comment 3

[william.allen.simpson]

Attachment: mozilla folder after POP

Here is the state of the folder after POP.

Note the new date for m-bugs.all is Today, 1:47 pm.  But no .msf file was generated.

Comment 4

[william.allen.simpson]

Attachment: list view after clicking

I should have taken a screen shot showing that the list view was unchanged after POP, but that's obvious from the previous attachment.

Here I show that it updated by clicking on the folder.

Comment 5

[william.allen.simpson]

Attachment: mozilla folder after clicking

After clicking, the new m-bugs.all.msf was generated.

Comment 6

[David :Bienvenu]

Not a regression. pop3 filters have never caused a regeneration of out of date or missing .msf files. This is most likely a dup of a longstanding bug.

Comment 7

[william.allen.simpson]

(In reply to David :Bienvenu from comment #6)
> Not a regression. pop3 filters have never caused a regeneration of out of
> date or missing .msf files. This is most likely a dup of a longstanding bug.

Hmmm, circa 2001-2002 I thought we'd planned that every time the mail was moved from file to file (which is what the mail filter does), the .msf would be updated. I'll have to search the old email archives, as soon as your Bug 682731 patch is committed and I can regenerate my indices. ;-)

Which outstanding bug?

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to David :Bienvenu from comment #6)
>  This is most likely a dup of a longstanding bug.

Comment 9

[David :Bienvenu]

(In reply to william.allen.simpson from comment #7)
> Hmmm, circa 2001-2002 I thought we'd planned that every time the mail was
> moved from file to file (which is what the mail filter does), the .msf would
> be updated.

The issue is that reparsing the folder to generate the .msf file is asynchronous, so you don't want to start doing it in the middle of a get new mail action, because it's quite possible that you'd get another message that needed to be filtered to the same destination folder, and you can't add messages to a folder while a reparse is going on. So the reparse would need to be deferred until the get new mail process is done, which means doing something like reparsing on idle. Not impossible, but not trivial.

> Which outstanding bug?
I don't know off the top of my head.

Comment 10

[Wayne Mery (:wsmwk)]

(In reply to David :Bienvenu from comment #9)
> > Which outstanding bug?
> I don't know off the top of my head.

Perhaps the bug you are thinking of is is one of the queries below. (this is a quick hack so these are aren't necessarily great queries)

https://bugzilla.mozilla.org/buglist.cgi?type1-0-0=substring;list_id=2581087;value2-0-1=filter;field0-0-0=short_desc;type0-0-1=substring;field0-0-1=component;value2-0-0=filter;type1-0-1=allwordssubstr;resolution=---;value1-0-1=msf;field2-0-0=short_desc;classification=Client%20Software;classification=Components;value0-0-2=pop;type2-0-0=substring;query_format=advanced;type2-0-1=substring;value1-0-0=msf;field0-0-2=longdesc;value0-0-1=pop;type0-0-0=anywords;value0-0-0=pop;field1-0-0=short_desc;product=MailNews%20Core;product=Thunderbird;type0-0-2=anywords;field1-0-1=longdesc;field2-0-1=component

https://bugzilla.mozilla.org/buglist.cgi?type1-0-0=substring;list_id=2581062;field0-0-0=short_desc;type0-0-1=substring;field0-0-1=component;type1-0-1=allwordssubstr;resolution=---;value1-0-1=msf;classification=Client%20Software;classification=Components;query_format=advanced;value1-0-0=msf;value0-0-1=pop;type0-0-0=anywords;value0-0-0=pop;field1-0-0=short_desc;product=MailNews%20Core;product=Thunderbird;field1-0-1=longdesc