Closed
Bug 682758
Opened 13 years ago
Closed 13 years ago
SimpleTest.js repr() causes a JS error and makes is() slow
Categories
(Testing :: Mochitest, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(1 file, 1 obsolete file)
1.96 KB,
patch
|
mdas
:
review+
|
Details | Diff | Splinter Review |
Line 51: reprRegistry.match(o); is calling match() on an empty Array and is triggering js_ReportIsNotFunction. This appears to be painfully slow because of bug 676934. I've attached a simple fix that just removes this broken check. This takes the runtime of layout/style/test/test_transitions_per_property.html from almost 3 minutes, down to 1 minute on my computer.
Attachment #556449 -
Flags: review?(mdas)
Comment 1•13 years ago
|
||
Comment on attachment 556449 [details] [diff] [review] Simple fix Review of attachment 556449 [details] [diff] [review]: ----------------------------------------------------------------- Great catch, and thanks for the patch, it looks good. ::: testing/mochitest/tests/SimpleTest/SimpleTest.js @@ +55,1 @@ > } catch (e) { Do you think you can add a comment here about why we don't grab the stack trace and the related bug number? It would deter people from doing this in the future.
Attachment #556449 -
Flags: review?(mdas) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Looks like that bug has landed now, so theres no reason to remove the catch{} block. Changed the patch to just remove the reprRegistry code that was causing the actual error.
Attachment #556449 -
Attachment is obsolete: true
Attachment #557072 -
Flags: review?
Assignee | ||
Updated•13 years ago
|
Attachment #557072 -
Flags: review? → review?(mdas)
Comment 3•13 years ago
|
||
Comment on attachment 557072 [details] [diff] [review] Simple fix v2 Review of attachment 557072 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Attachment #557072 -
Flags: review?(mdas) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Landed on inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/2bf8e6118af4
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/2bf8e6118af4
Assignee: nobody → matt.woodrow
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•