682867 - Builtin native commands should fall back to the shell if shell metacharacters are present

Status: NEW

(Firefox Build System :: General, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

I haven't actually tested this but it should work.  For actual native commands we'll just die in the shell; I think that's ok.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 556579 [details] [diff] [review]
Patch

Review of attachment 556579 [details] [diff] [review]:
-----------------------------------------------------------------

::: pymake/data.py
@@ +1230,5 @@
> +                                         loc=c.loc, context=makefile.context,
> +                                         echo=echo, justprint=makefile.justprint,
> +                                         pycommandpath=e)
> +                except NeedsFullShellError:
> +                    isNative = False

This will just fail in a different way, since even things like $(RM) are "pymake.builtins rm". We need a better solution.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yeah, this won't work then.  As I said on IRC though, it really sucks that $(RM) isn't safe to use in shell expressions in pymake.