682906 - Allow building Lightning as an app (without building Thunderbird)

Status: RESOLVED INVALID

(Calendar :: Build Config, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: WiP - v1

To improve build speed and remove the need to build Thunderbird, we should investigate building Lightning with --enable-application=calendar/lightning. I'd still avoid making this the default strategy for new contributors, since they'd have to afterwards install lightning into a Thunderbird nightly via file link and this might not catch everything.

But, this is great for our builders and such. The attached patch also moves around some files and directories so that calendar/lightning isn't cluttered.

Comment 1

[Felix Möller]

Does this basically mean that something like Sunbird will be there again?

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

No, this is merely build config. With "as an app" I mean application in the sense of passing something lightning specific to the --enable-application=... option of the mozilla build system.

Comment 3

[Orion Poplawski]

Attachment: rebased for lightning-1.4

This didn't apply to lightning-1.4 with fuzz=0, so here is a rebased version.

Do you still need to specify --enable-calendar with this or not?  Thanks for this, it will be very helpful for building the Fedora packages.  At the moment it isn't working for me though, getting:

c++ -o nsXPComInit.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/config/gcc_hidden.h -DXP_LINUX -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DSTATIC_EXPORTABLE_JS_API -DOSTYPE=\"Linux2.6.43.2-6.fc15\" -DOSARCH=Linux -DEXCLUDE_SKIA_DEPENDENCIES  -DOS_LINUX=1 -DOS_POSIX=1  -D_IMPL_NS_COM -D_IMPL_NS_STRINGAPI -DEXPORT_XPT_API -DEXPORT_XPTC_API -DOMNIJAR_NAME="omni.ja"  -DTARGET_XPCOM_ABI=\"x86_64-gcc3\" -I/builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/xpcom/build -I.. -I/builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/xpcom/build/../glue -I/builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/xpcom/build/../base -I/builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/xpcom/build/../ds -I/builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/xpcom/build/../io -I/builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/xpcom/build/../components -I/builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/xpcom/build/../threads -I/builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/xpcom/build/../reflect/xptinfo/src -I/builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/chrome/src -I/builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/xpcom/build/../../docshell/base  -I/builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/ipc/chromium/src -I/builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/ipc/glue -I../../ipc/ipdl/_ipdlheaders  -I/builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/xpcom/build -I. -I../../dist/include -I../../dist/include/nsprpub  -I/usr/include/nspr4 -I/usr/include/nss3      -fPIC -fno-rtti -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -Wno-long-long -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fno-exceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -fpermissive -fno-exceptions -fno-strict-aliasing -std=gnu++0x -pthread -ffunction-sections -fdata-sections -pipe -DNDEBUG -DTRIMMED -g -Os -freorder-blocks  -fomit-frame-pointer   -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MF .deps/nsXPComInit.pp /builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/xpcom/build/nsXPComInit.cpp
In file included from /builddir/build/BUILD/thunderbird-lightning-1.4/comm-beta/mozilla/xpcom/build/nsXPComInit.cpp:143:0:
../../dist/include/mozilla/scache/StartupCache.h:46:26: fatal error: nsIZipWriter.h: No such file or directory

Comment 4

[Orion Poplawski]

Hmm, scratch that, my rebase didn't catch the renames.  Try again...

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

No --enable-calendar should be needed.

Comment 6

[Orion Poplawski]

(In reply to Philipp Kewisch [:Fallen] (away until May 28th) from comment #5)
> No --enable-calendar should be needed.

I parse that as keep --enable-calendar.

Looks like it just doesn't apply cleanly to lightning 1.4.  Could I get an updated patch?  Thanks.

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: rebased for lightning-1.7

Here is a patch that applies on comm-central, although I haven't tested if it still works.

Comment 8

[Orion Poplawski]

We're just now building 1.6, so can't yet test.

Comment 9

[Martin Schröder [:mschroeder]]

Philipp, do you think this bug reports needs to be kept for Lightning as the code is now integrated with Thunderbird?

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

Good to close, thanks!