682921 - Change debug ifdef to DEBUG_ANDROID_FOO instead of ANDROID_DEBUG_FOO

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

You can enable debug defines with --with-debug-label=FOO, which will #define DEBUG_FOO.  This doesn't work with our Fennec/Android ones, though, since they are ANDROID_DEBUG_FOO.  It is annoying, since you have to edit source files and clean that stuff up before creating a patch.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 682921 - Use DEBUG_ANDROID_FOO instead of ANDROID_DEBUG_FOO

This allows people to use the --with-debug-label configure options
instead of editing source files.

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 556626 [details] [diff] [review]
Bug 682921 - Use DEBUG_ANDROID_FOO instead of ANDROID_DEBUG_FOO

This looks fine to me; passing review to Doug since I think he'd me more likely to spot any problems this would cause.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 556626 [details] [diff] [review]
Bug 682921 - Use DEBUG_ANDROID_FOO instead of ANDROID_DEBUG_FOO

make sure it builds

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Seems to build fine, and setting things using --with-debug-label works

Comment 5

[Ed Morley [:emorley]]

In my queue :-)

Comment 6

[Ed Morley [:emorley]]

Meant to say that the attached patch was a bit mangled (double 'from' line, version numbers at EOF etc), which meant it didn't parse properly for me without manual editing (I've fixed it now, so no need to upload again here). For the future, can you double check that your hgrc is set up something like that at http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed please - thanks :-)

Comment 7

[Ed Morley [:emorley]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e817b1753380

Comment 8

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/e817b1753380