Closed Bug 682921 Opened 9 years ago Closed 9 years ago
Change debug ifdef to DEBUG
_ANDROID _FOO instead of ANDROID _DEBUG _FOO
You can enable debug defines with --with-debug-label=FOO, which will #define DEBUG_FOO. This doesn't work with our Fennec/Android ones, though, since they are ANDROID_DEBUG_FOO. It is annoying, since you have to edit source files and clean that stuff up before creating a patch.
This allows people to use the --with-debug-label configure options instead of editing source files.
9 years ago
Attachment #556626 - Flags: review?(mbrubeck)
Comment on attachment 556626 [details] [diff] [review] Bug 682921 - Use DEBUG_ANDROID_FOO instead of ANDROID_DEBUG_FOO This looks fine to me; passing review to Doug since I think he'd me more likely to spot any problems this would cause.
Attachment #556626 - Flags: review?(mbrubeck) → review?(doug.turner)
Comment on attachment 556626 [details] [diff] [review] Bug 682921 - Use DEBUG_ANDROID_FOO instead of ANDROID_DEBUG_FOO make sure it builds
Attachment #556626 - Flags: review?(doug.turner) → review+
Seems to build fine, and setting things using --with-debug-label works
In my queue :-)
Meant to say that the attached patch was a bit mangled (double 'from' line, version numbers at EOF etc), which meant it didn't parse properly for me without manual editing (I've fixed it now, so no need to upload again here). For the future, can you double check that your hgrc is set up something like that at http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed please - thanks :-)
Target Milestone: --- → Firefox 9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.