Last Comment Bug 682925 - Remove a duplicate #ifdef/if pair in vm/Stack.cpp.
: Remove a duplicate #ifdef/if pair in vm/Stack.cpp.
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: mozilla9
Assigned To: Terrence Cole [:terrence]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-29 11:56 PDT by Terrence Cole [:terrence]
Modified: 2011-08-31 02:06 PDT (History)
4 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
The trivial fix. (1.50 KB, patch)
2011-08-29 11:56 PDT, Terrence Cole [:terrence]
luke: review+
emorley: checkin+
Details | Diff | Review

Description Terrence Cole [:terrence] 2011-08-29 11:56:39 PDT
Created attachment 556632 [details] [diff] [review]
The trivial fix.

This logic can be better expressed by moving the outer if condition directly into the JS_ASSERT_IF and removing the #ifdef DEBUG.
Comment 1 Luke Wagner [:luke] 2011-08-29 13:33:27 PDT
Comment on attachment 556632 [details] [diff] [review]
The trivial fix.

Nice, thanks!

Need checking?
Comment 2 Luke Wagner [:luke] 2011-08-29 13:33:50 PDT
Oops, s/Need checking/Need checkin/.
Comment 3 Terrence Cole [:terrence] 2011-08-29 14:24:58 PDT
Comment on attachment 556632 [details] [diff] [review]
The trivial fix.

Indeed I do, and thank you for the offer.
Comment 4 Ed Morley [:emorley] 2011-08-30 11:28:27 PDT
In my queue :-)
Comment 6 Marco Bonardo [::mak] 2011-08-31 02:06:21 PDT
http://hg.mozilla.org/mozilla-central/rev/6eaa9655a1cf

Note You need to log in before you can comment on or make changes to this bug.