Remove a duplicate #ifdef/if pair in vm/Stack.cpp.

RESOLVED FIXED in mozilla9

Status

()

Core
JavaScript Engine
--
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla9
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 556632 [details] [diff] [review]
The trivial fix.

This logic can be better expressed by moving the outer if condition directly into the JS_ASSERT_IF and removing the #ifdef DEBUG.
Attachment #556632 - Flags: review?(luke)

Comment 1

6 years ago
Comment on attachment 556632 [details] [diff] [review]
The trivial fix.

Nice, thanks!

Need checking?
Attachment #556632 - Flags: review?(luke) → review+

Comment 2

6 years ago
Oops, s/Need checking/Need checkin/.
(Assignee)

Comment 3

6 years ago
Comment on attachment 556632 [details] [diff] [review]
The trivial fix.

Indeed I do, and thank you for the offer.
Attachment #556632 - Flags: checkin?(luke)

Comment 4

6 years ago
In my queue :-)
Assignee: general → terrence
Status: NEW → ASSIGNED
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Version: Other Branch → Trunk

Comment 5

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/6eaa9655a1cf
Target Milestone: --- → mozilla9

Updated

6 years ago
Attachment #556632 - Flags: checkin?(luke) → checkin+
http://hg.mozilla.org/mozilla-central/rev/6eaa9655a1cf
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.