Closed
Bug 682925
Opened 13 years ago
Closed 13 years ago
Remove a duplicate #ifdef/if pair in vm/Stack.cpp.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: terrence, Assigned: terrence)
Details
Attachments
(1 file)
|
1.50 KB,
patch
|
luke
:
review+
emorley
:
checkin+
|
Details | Diff | Splinter Review |
This logic can be better expressed by moving the outer if condition directly into the JS_ASSERT_IF and removing the #ifdef DEBUG.
Attachment #556632 -
Flags: review?(luke)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 556632 [details] [diff] [review] The trivial fix. Nice, thanks! Need checking?
Attachment #556632 -
Flags: review?(luke) → review+
|
|
||
Comment 2•13 years ago
|
||
Oops, s/Need checking/Need checkin/.
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 556632 [details] [diff] [review] The trivial fix. Indeed I do, and thank you for the offer.
Attachment #556632 -
Flags: checkin?(luke)
|
||
Comment 4•13 years ago
|
||
In my queue :-)
Assignee: general → terrence
Status: NEW → ASSIGNED
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Version: Other Branch → Trunk
|
|
||
Comment 5•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/6eaa9655a1cf
Target Milestone: --- → mozilla9
|
|
||
Updated•13 years ago
|
Attachment #556632 -
Flags: checkin?(luke) → checkin+
|
||
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/6eaa9655a1cf
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•