683025 - Add a check_for_edit to Bugzilla::Bug to return the bug object if the user can edit the bug

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Robert Webb]

There should be a check_for_edit method in Bugzilla::Bug that will run check and take that bug and run can_edit_product. This will either throw a user error if they do not have permissions to edit the bug or will return the created bug object.

Comment 1

[Frédéric Buclin]

IMO, this doesn't make sense. It should be a User object method, like $user->can_edit_bug($bug)

Comment 2

[Max Kanat-Alexander]

No, it's:

  my $bug = Bugzilla::Bug->check_for_edit($id);

Comment 3

[Robert Webb]

Attachment: Adding check_for_edit to Bugzilla::Bug

Comment 4

[Max Kanat-Alexander]

Comment on attachment 556967 [details] [diff] [review]
Adding check_for_edit to Bugzilla::Bug

Review of attachment 556967 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good on the implementation, but in order for us to accept patches, we require that the code actually be used somewhere. So just convert all the places where we call check() and then can_edit_product into a call to this.

Comment 5

[Robert Webb]

Attachment: Adding check_for_edit to Bugzilla::Bug change v2

Updated the changes and patched all of the places where User->can_edit_product is called after Bug->check.

Comment 6

[Max Kanat-Alexander]

Comment on attachment 557026 [details] [diff] [review]
Adding check_for_edit to Bugzilla::Bug change v2

Review of attachment 557026 [details] [diff] [review]:
-----------------------------------------------------------------

Beautiful! This is a very nice cleanup. :-)

Comment 7

[Frédéric Buclin]

Comment on attachment 557026 [details] [diff] [review]
Adding check_for_edit to Bugzilla::Bug change v2

>=== modified file 'Bugzilla/Bug.pm'

>+    Bugzilla->user->can_edit_product($bug->{product_id})

Nit: should be ->product_id instead of ->{product_id}

Comment 8

[Robert Webb]

Attachment: Adding check_for_edit to Bugzilla::Bug change v3

Updating the diff for the nit pick.

Comment 9

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified process_bug.cgi
modified Bugzilla/Bug.pm
modified Bugzilla/BugUrl/Bugzilla/Local.pm
modified Bugzilla/WebService/Bug.pm
Committed revision 7949.