683152 - Homepage doesn't validate

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Scoobidiver (away)]

In addition to the errors and warning in bug 574543, there's one more error in the homepage:
http://validator.w3.org/check?uri=http%3A%2F%2Fsupport.allizom.org&charset=%28detect+automatically%29&doctype=Inline&group=0&user-agent=W3C_Validator%2F1.2
The select element cannot have more than one selected option descendant unless the multiple attribute is specified.
…ta-dependency="mobile" selected="selected" data-default="true">Android</option>

Comment 1

[James Socol [:jsocol, :james]]

This may go away on it's own: if it's not fixed after the 9-06 push I'll look into it.

Comment 2

[Scoobidiver (away)]

(In reply to James Socol [:jsocol, :james] from comment #1)
> This may go away on it's own: if it's not fixed after the 9-06 push I'll
> look into it.
Not fixed. See: http://validator.w3.org/check?uri=http%3A%2F%2Fsupport.mozilla.com%2Fen-US%2Fhome&charset=%28detect+automatically%29&doctype=Inline&group=0&user-agent=W3C_Validator%2F1.2

Comment 3

[James Socol [:jsocol, :james]]

So, the problem is that Android and Windows are both "default" operating systems, which I think is necessary for the showfor JS right now.

If I change it not to set selected="selected" on the second "default", it seems to work, and the qunit tests all still pass.

Comment 4

[James Socol [:jsocol, :james]]

Actually, no, what I'm doing doesn't work.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Fixed by:
https://github.com/jsocol/kitsune/commit/76698097e27f06126bc58024d385f8d5c3a39d7e

Comment 6

[Rebecca Billings [:rbillings]]

I'm seeing this same error on support: http://validator.w3.org/check?uri=https%3A%2F%2Fsupport.allizom.org%2Fen-US%2Fhome&charset=%28detect+automatically%29&doctype=Inline&group=0

Please comment if this can only be verified after the release.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Rebecca Billings from comment #6)
> I'm seeing this same error on support:
> http://validator.w3.org/check?uri=https%3A%2F%2Fsupport.allizom.org%2Fen-
> US%2Fhome&charset=%28detect+automatically%29&doctype=Inline&group=0

I am seeing "This document was successfully checked as HTML5!". Maybe stage wasn't completely updated yet at the time?

Comment 8

[Rebecca Billings [:rbillings]]

Stage must have been in transition, as it does check out now. Marking as verified.