The default bug view has changed. See this FAQ.

make -C browser/install on cross compiler is always failed

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: m_kato, Assigned: glandium)

Tracking

({regression})

Trunk
All
Linux
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
this is a regression of bug 655678.  Since GENRATE_CACHE is 1 on cross, make -C browser/installer is always failed.

cd ../../dist && (cd firefox && rm -f omni.jar components/binary.manifest && grep -h '^binary-component' components/*.manifest > binary.manifest ; for m in components/*.manifest; do sed -e 's/^binary-component/#binary-component/' $m > tmp.manifest && mv tmp.manifest $m; done; /usr/bin/zip -r9m omni.jar chrome chrome.manifest components/*.js components/*.xpt components/*.manifest modules res defaults greprefs.js jsloader  -x chrome/icons/\* defaults/pref/channel-prefs.js res/cursors/\* res/MainMenu.nib/\*  && 1 && /usr/bin/python2.6 /home/makoto/Development/hg.mozilla.org/mozilla-arm/config/optimizejars.py --optimize /home/makoto/Development/hg.mozilla.org/objdir-arm/browser/installer/../../jarlog//en-US ./ ./ && mv binary.manifest components && printf "manifest components/binary.manifest\n" > chrome.manifest) && (cd firefox && /usr/bin/python2.6 /home/makoto/Development/hg.mozilla.org/mozilla-arm/config/createprecomplete.py) && tar -c --owner=0 --group=0 --numeric-owner --mode="go-w" -f - firefox | bzip2 -vf > firefox-9.0a1.en-US.linux-gnueabi-arm.tar.bz2

...
  adding: defaults/pref/services-sync.js (deflated 76%)
  adding: defaults/pref/firefox.js (deflated 75%)
  adding: greprefs.js (deflated 73%)
/bin/sh: 1: not found
make[1]: *** [make-package] Error 127
make[1]: Leaving directory `/home/makoto/Development/hg.mozilla.org/objdir-arm/browser/installer'
(Reporter)

Updated

6 years ago
Keywords: regression
(Assignee)

Comment 1

6 years ago
Created attachment 556859 [details] [diff] [review]
Properly disable GENERATE_CACHE when cross compiling
Attachment #556859 - Flags: review?(khuey)
(Reporter)

Updated

6 years ago
Assignee: m_kato → mh+mozilla
Attachment #556859 - Flags: review?(khuey) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/projects/build-system/rev/3edb52f6710d
Whiteboard: fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/3edb52f6710d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
(Reporter)

Comment 4

6 years ago
This fix is incorrect.  Build error still occurs.   Please set true instead of empty string.


Compressing...
cd ../../dist && (cd firefox && rm -f omni.jar components/binary.manifest && grep -h '^binary-component' components/*.manifest > binary.manifest ; for m in components/*.manifest; do sed -e 's/^binary-component/#binary-component/' $m > tmp.manifest && mv tmp.manifest $m; done; /usr/bin/zip -r9m omni.jar chrome chrome.manifest components/*.js components/*.xpt components/*.manifest modules res defaults greprefs.js jsloader  -x chrome/icons/\* defaults/pref/channel-prefs.js res/cursors/\* res/MainMenu.nib/\*  &&  && /usr/bin/python2.6 /home/makoto/Development/hg.mozilla.org/mozilla-arm/config/optimizejars.py --optimize /home/makoto/Development/hg.mozilla.org/objdir-arm/browser/installer/../../jarlog//en-US ./ ./ && mv binary.manifest components && printf "manifest components/binary.manifest\n" > chrome.manifest) && (cd firefox && /usr/bin/python2.6 /home/makoto/Development/hg.mozilla.org/mozilla-arm/config/createprecomplete.py) && tar -c --owner=0 --group=0 --numeric-owner --mode="go-w" -f - firefox | bzip2 -vf > firefox-9.0a1.en-US.linux-gnueabi-arm.tar.bz2
/bin/sh: Syntax error: "&&" unexpected
make[1]: *** [make-package] Error 2
make[1]: Leaving directory `/home/makoto/Development/hg.mozilla.org/objdir-arm/browser/installer'
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

6 years ago
*sigh*, the make logic:

FOO=
ifdef FOO
$(error FOO)
endif
FOO?=true

foo:
        @echo $(FOO)

make -> displays nothing.
(Assignee)

Comment 6

6 years ago
That behaviour is even documented:
http://www.gnu.org/software/make/manual/make.html#Flavors

Note that a variable set to an empty value is still defined, so ‘?=’ will not set that variable.
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/projects/build-system/rev/61dc35b8f63f
http://hg.mozilla.org/mozilla-central/rev/61dc35b8f63f
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
The whole b-s merge backed out of m-c for causing bustage:
http://hg.mozilla.org/mozilla-central/rev/472716252ea3

https://tbpl.mozilla.org/?usebuildbot=1&rev=e5815c156b6c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: fixed-in-bs
Target Milestone: mozilla9 → ---

Updated

6 years ago
Duplicate of this bug: 673711
(Assignee)

Comment 11

6 years ago
I backed out the back out on b-s.
Whiteboard: fixed-in-bs
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.