Closed Bug 683171 Opened 8 years ago Closed 8 years ago

make -C browser/install on cross compiler is always failed

Categories

(Firefox Build System :: General, defect)

All
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: m_kato, Assigned: glandium)

References

Details

(Keywords: regression, Whiteboard: fixed-in-bs)

Attachments

(1 file)

this is a regression of bug 655678.  Since GENRATE_CACHE is 1 on cross, make -C browser/installer is always failed.

cd ../../dist && (cd firefox && rm -f omni.jar components/binary.manifest && grep -h '^binary-component' components/*.manifest > binary.manifest ; for m in components/*.manifest; do sed -e 's/^binary-component/#binary-component/' $m > tmp.manifest && mv tmp.manifest $m; done; /usr/bin/zip -r9m omni.jar chrome chrome.manifest components/*.js components/*.xpt components/*.manifest modules res defaults greprefs.js jsloader  -x chrome/icons/\* defaults/pref/channel-prefs.js res/cursors/\* res/MainMenu.nib/\*  && 1 && /usr/bin/python2.6 /home/makoto/Development/hg.mozilla.org/mozilla-arm/config/optimizejars.py --optimize /home/makoto/Development/hg.mozilla.org/objdir-arm/browser/installer/../../jarlog//en-US ./ ./ && mv binary.manifest components && printf "manifest components/binary.manifest\n" > chrome.manifest) && (cd firefox && /usr/bin/python2.6 /home/makoto/Development/hg.mozilla.org/mozilla-arm/config/createprecomplete.py) && tar -c --owner=0 --group=0 --numeric-owner --mode="go-w" -f - firefox | bzip2 -vf > firefox-9.0a1.en-US.linux-gnueabi-arm.tar.bz2

...
  adding: defaults/pref/services-sync.js (deflated 76%)
  adding: defaults/pref/firefox.js (deflated 75%)
  adding: greprefs.js (deflated 73%)
/bin/sh: 1: not found
make[1]: *** [make-package] Error 127
make[1]: Leaving directory `/home/makoto/Development/hg.mozilla.org/objdir-arm/browser/installer'
Keywords: regression
Assignee: m_kato → mh+mozilla
http://hg.mozilla.org/mozilla-central/rev/3edb52f6710d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
This fix is incorrect.  Build error still occurs.   Please set true instead of empty string.


Compressing...
cd ../../dist && (cd firefox && rm -f omni.jar components/binary.manifest && grep -h '^binary-component' components/*.manifest > binary.manifest ; for m in components/*.manifest; do sed -e 's/^binary-component/#binary-component/' $m > tmp.manifest && mv tmp.manifest $m; done; /usr/bin/zip -r9m omni.jar chrome chrome.manifest components/*.js components/*.xpt components/*.manifest modules res defaults greprefs.js jsloader  -x chrome/icons/\* defaults/pref/channel-prefs.js res/cursors/\* res/MainMenu.nib/\*  &&  && /usr/bin/python2.6 /home/makoto/Development/hg.mozilla.org/mozilla-arm/config/optimizejars.py --optimize /home/makoto/Development/hg.mozilla.org/objdir-arm/browser/installer/../../jarlog//en-US ./ ./ && mv binary.manifest components && printf "manifest components/binary.manifest\n" > chrome.manifest) && (cd firefox && /usr/bin/python2.6 /home/makoto/Development/hg.mozilla.org/mozilla-arm/config/createprecomplete.py) && tar -c --owner=0 --group=0 --numeric-owner --mode="go-w" -f - firefox | bzip2 -vf > firefox-9.0a1.en-US.linux-gnueabi-arm.tar.bz2
/bin/sh: Syntax error: "&&" unexpected
make[1]: *** [make-package] Error 2
make[1]: Leaving directory `/home/makoto/Development/hg.mozilla.org/objdir-arm/browser/installer'
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
*sigh*, the make logic:

FOO=
ifdef FOO
$(error FOO)
endif
FOO?=true

foo:
        @echo $(FOO)

make -> displays nothing.
That behaviour is even documented:
http://www.gnu.org/software/make/manual/make.html#Flavors

Note that a variable set to an empty value is still defined, so ‘?=’ will not set that variable.
http://hg.mozilla.org/mozilla-central/rev/61dc35b8f63f
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
The whole b-s merge backed out of m-c for causing bustage:
http://hg.mozilla.org/mozilla-central/rev/472716252ea3

https://tbpl.mozilla.org/?usebuildbot=1&rev=e5815c156b6c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: fixed-in-bs
Target Milestone: mozilla9 → ---
Duplicate of this bug: 673711
I backed out the back out on b-s.
Whiteboard: fixed-in-bs
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.