Closed Bug 683254 Opened 8 years ago Closed 8 years ago
On startup with no network, sync icon spins endlessly
10-15 seconds after start up, a sync is fired by schedule. If there is no network connection, the sync icon continuously spins. I believe the icon should stop spinning once Sync finds it has no network connection.
Note that the clearError() method will be used more effectively in 682954.
Attachment #556969 - Flags: review?(philipp)
Comment on attachment 556969 [details] [diff] [review] V1: update UI on login:error when errors are not reported one nit: clear-error instead of clear:error r=me with that
Attachment #556969 - Flags: review?(philipp) → review+
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [fixed in services]
verified on s-c with build of late 8/30 - 1314744175 no more endless spinning.
Whiteboard: [fixed in services] → veri[fied in services]
Whiteboard: veri[fied in services] → [verified in services]
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
So, are the two occurrences of Weave.Notifications.removeAll(); left (in onLoginError and onSyncError) oversights, not to be adapted for some reason, or to be done in the bug comment 1 points at?
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #7) > So, are the two occurrences of Weave.Notifications.removeAll(); left (in > onLoginError and onSyncError) oversights, not to be adapted for some reason, > or to be done in the bug comment 1 points at? Good observation! Yep those two will be handled in the bug that comment 1 points to. There's a lot of improvements/changes to be done around UI error handling and in this bug I just added a quick little tidbit of it.
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.