683301 - Search filters should not disappear unless the user switches to a *category* that doesn't use them

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P3)

Description

[Daniel Buchner [:dbuc]]

If you take a look here: https://builder-addons.allizom.org/search/?type=l&copies=0&used=0 - you will see it shows two filter sliders, on is relevant to only search. If you slide either all the way to the right, the results update and the other slider disappears.

I understand why we are doing this: the other slider no longer applies as no results are left that could be filtered by it. However, I do not want to have the UI jumping around and disappearing. We should use the .detach() method on the slider that is not able to be used, and change its styles to appear disabled (as one would do with an inapplicable input).

Please ping me for clarification if needed.

Comment 1

[Sean McArthur [:seanmonstar]]

fixed on master

https://github.com/mozilla/FlightDeck/commit/19324f89b35a2222c72a95f6be2fdff11cbcab48

Comment 2

[Zac C (:zac)]

Sliders are persisting. Their state changes to disabled with a fancy icon.