Incorrect check for resizers in content

RESOLVED FIXED in mozilla10

Status

()

Core
XP Toolkit/Widgets: XUL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Neil Deakin (not available until Aug 9), Assigned: Neil Deakin (not available until Aug 9))

Tracking

(Blocks: 1 bug)

Trunk
mozilla10
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 557049 [details] [diff] [review]
patch

The check in nsResizer.cpp is reversed and should block resizers in content. Also, native resizing should also be disabled in content.

The test will be posted to bug 659338.
Attachment #557049 - Flags: review?(neil)
Blocks: 680823

Comment 1

6 years ago
Comment on attachment 557049 [details] [diff] [review]
patch

>         }
>         else {
>+          doDefault = PR_FALSE;
>+
>+          // If there is no window, then resizing isn't allowed.
>+          if (!window)
>+            break;
...
>         }
...
>-        doDefault = PR_FALSE;
I don't understand this change. In particular, you set doDefault to false even if there is no window, and fail to set it to false when you have content to resize. Or was that intentional?
Created attachment 562452 [details] [diff] [review]
patch, moved doDefault lines

I moved the lines which set doDefault.

- the content block should have been setting it to false as well.
- I moved the second one after the window is not null check, although if there's no window, then it doesn't seem like it matters what happens here.
Attachment #557049 - Attachment is obsolete: true
Attachment #557049 - Flags: review?(neil)
Attachment #562452 - Flags: review?(neil)

Comment 3

6 years ago
Comment on attachment 562452 [details] [diff] [review]
patch, moved doDefault lines

(In reply to comment #2)
> it doesn't seem like it matters what happens here.
I think we should only set doDefault to false if we process the click.
Attachment #562452 - Flags: review?(neil) → review+
https://hg.mozilla.org/mozilla-central/rev/df24b0cffd01
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.