Closed Bug 683394 Opened 9 years ago Closed 9 years ago

Incorrect check for resizers in content

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: enndeakin, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
The check in nsResizer.cpp is reversed and should block resizers in content. Also, native resizing should also be disabled in content.

The test will be posted to bug 659338.
Attachment #557049 - Flags: review?(neil)
Blocks: 680823
Comment on attachment 557049 [details] [diff] [review]
patch

>         }
>         else {
>+          doDefault = PR_FALSE;
>+
>+          // If there is no window, then resizing isn't allowed.
>+          if (!window)
>+            break;
...
>         }
...
>-        doDefault = PR_FALSE;
I don't understand this change. In particular, you set doDefault to false even if there is no window, and fail to set it to false when you have content to resize. Or was that intentional?
I moved the lines which set doDefault.

- the content block should have been setting it to false as well.
- I moved the second one after the window is not null check, although if there's no window, then it doesn't seem like it matters what happens here.
Attachment #557049 - Attachment is obsolete: true
Attachment #557049 - Flags: review?(neil)
Attachment #562452 - Flags: review?(neil)
Comment on attachment 562452 [details] [diff] [review]
patch, moved doDefault lines

(In reply to comment #2)
> it doesn't seem like it matters what happens here.
I think we should only set doDefault to false if we process the click.
Attachment #562452 - Flags: review?(neil) → review+
https://hg.mozilla.org/mozilla-central/rev/df24b0cffd01
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Flags: in-testsuite+
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.