683394 - Incorrect check for resizers in content

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Neil Deakin]

Attachment: patch

The check in nsResizer.cpp is reversed and should block resizers in content. Also, native resizing should also be disabled in content.

The test will be posted to bug 659338.

Comment 1

[[e-mail]]

Comment on attachment 557049 [details] [diff] [review]
patch

>         }
>         else {
>+          doDefault = PR_FALSE;
>+
>+          // If there is no window, then resizing isn't allowed.
>+          if (!window)
>+            break;
...
>         }
...
>-        doDefault = PR_FALSE;
I don't understand this change. In particular, you set doDefault to false even if there is no window, and fail to set it to false when you have content to resize. Or was that intentional?

Comment 2

[Neil Deakin]

Attachment: patch, moved doDefault lines

I moved the lines which set doDefault.

- the content block should have been setting it to false as well.
- I moved the second one after the window is not null check, although if there's no window, then it doesn't seem like it matters what happens here.

Comment 3

[[e-mail]]

Comment on attachment 562452 [details] [diff] [review]
patch, moved doDefault lines

(In reply to comment #2)
> it doesn't seem like it matters what happens here.
I think we should only set doDefault to false if we process the click.

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/df24b0cffd01

Comment 5

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336