68343 - OS/2 can't print on the current trunk (0.8)

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[Mike Kaply [:mkaply]]

Due to rods printoptions changes, OS/2 can't print.

We discovered that we need to change the component registration code on OS/2.

I already have everything rewritten - the only XP change is in 
nsSetupRegistry.cpp.

I'll attach that diff to this bug.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Take unix path on OS/2 for GFX in nssetupregistry

Comment 2

[Mike Kaply [:mkaply]]

I should have assigned this to me.

Comment 3

[Christopher Blizzard (:blizzard)]

There are some OS/2 specific defines in the nsSetupRegistry in xpfe/bootstrap. 
Do you need to change any of those or do you need them because you have 8.3
filenames?

The patch here looks fine other than that.

Comment 4

[Mike Kaply [:mkaply]]

Yeah, we need those for 8.3 and otherwise.

What other approvals/sr= do I need here?

Comment 5

[Christopher Blizzard (:blizzard)]

Technically you have to have one other review.  I can sr= and approve for 0.8 so
that's taken care of.

Comment 6

[Stuart Parmenter]

r=pavlov

Comment 7

[Christopher Blizzard (:blizzard)]

You're all set, Michael.  Check it in.

Comment 8

[Mike Kaply [:mkaply]]

Fix checked in.

Comment 9

[Mike Kaply [:mkaply]]

Verified fixed.