Download script selects wrong locale for download

RESOLVED FIXED

Status

Mozilla QA Graveyard
Mozmill Automation
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Not sure what's wrong with the script but somehow we are downloading the wrong locale:

$ ./download.py --type=daily --locale=nl --platform=mac --directory=builds
Downloading build: http://stage.mozilla.org/pub/mozilla.org/firefox//nightly/latest-mozilla-central-l10n//firefox-9.0a1.fy-NL.mac.dmg
(Assignee)

Comment 1

6 years ago
Created attachment 557318 [details] [diff] [review]
Patch v1

This patch updates the regular expressions for the binary filename. We really have to check that the given locale is enclosed in dots. Otherwise we fetch the wrong build, e.g. nl -> fy-NL.

I have also update the helper strings in the download script to make it clear that when no date is given we download the latest build of the specified branch and that the version doesn't apply for daily builds.
Attachment #557318 - Flags: review?(dburns)

Comment 2

6 years ago
Comment on attachment 557318 [details] [diff] [review]
Patch v1

it might be better to dynamically generate the regex from component parts rather than having to change each regex for only a few things that vary
(Assignee)

Comment 3

6 years ago
Created attachment 557451 [details] [diff] [review]
Patch v1.1

Incorporates the proposal and moves out the regex for the base filename to it's own variable.
Attachment #557318 - Attachment is obsolete: true
Attachment #557318 - Flags: review?(dburns)
Attachment #557451 - Flags: review?(dave.hunt)

Updated

6 years ago
Attachment #557451 - Flags: review?(dave.hunt) → review+
(Assignee)

Comment 4

6 years ago
Landed as:
http://hg.mozilla.org/qa/mozmill-automation/rev/b2c3bc6d7ad8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.