683469 - Download script selects wrong locale for download

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Automation, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Not sure what's wrong with the script but somehow we are downloading the wrong locale:

$ ./download.py --type=daily --locale=nl --platform=mac --directory=builds
Downloading build: http://stage.mozilla.org/pub/mozilla.org/firefox//nightly/latest-mozilla-central-l10n//firefox-9.0a1.fy-NL.mac.dmg

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

This patch updates the regular expressions for the binary filename. We really have to check that the given locale is enclosed in dots. Otherwise we fetch the wrong build, e.g. nl -> fy-NL.

I have also update the helper strings in the download script to make it clear that when no date is given we download the latest build of the specified branch and that the version doesn't apply for daily builds.

Comment 2

[Jeff Hammel]

Comment on attachment 557318 [details] [diff] [review]
Patch v1

it might be better to dynamically generate the regex from component parts rather than having to change each regex for only a few things that vary

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1.1

Incorporates the proposal and moves out the regex for the base filename to it's own variable.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-automation/rev/b2c3bc6d7ad8