Closed Bug 683507 Opened 8 years ago Closed 8 years ago

assertion fired when constructing a Vector with the wrong number of parameters

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Q4 11 - Anza

People

(Reporter: brbaker, Assigned: lhansen)

References

Details

Attachments

(2 files)

var vError:Vector.<Number, int> = new Vector.<Number, int>;

In release builds this fires a RTE "TypeError: Error #1128: Incorrect number of type parameters", but in debug builds this asserts.

Assertion failed: "((argc==1))" ("../core/VectorClass.cpp":249)

Runtime behavior should be the same whether running debug or release builds.
Flags: in-testsuite?
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Flags: flashplayer-bug-
changeset: 6553:5c247366c666
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 683507: remove a test from the vector constructor testfile since it is asserting when run in debug mode. This testcase will be added back in as its own file (r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/5c247366c666
at the risk of stating the obvious: If the code can be refactored so the RTE happens before the assert, great, otherwise we should just remove the assert.
Attached patch testcaseSplinter Review
Testcase can be added in once this is resolved.
(In reply to Edwin Smith from comment #2)
> at the risk of stating the obvious: If the code can be refactored so the RTE
> happens before the assert, great, otherwise we should just remove the assert.

Looking at the code: the assert does not belong there.  OP_applytype specifically allows for a number of type parameters not equal to 1, and Vector restricts that and needs to be responsible for throwing the error.
Assignee: nobody → lhansen
Attached patch PatchSplinter Review
Obvious patch: remove the assert and move a comment to where it belongs.
Attachment #557430 - Flags: review?(edwsmith)
Blocks: 681888
Target Milestone: --- → Q4 11 - Anza
Attachment #557430 - Flags: review?(edwsmith) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
changeset: 6564:db7dd23cd076
user:      Lars T Hansen <lhansen@adobe.com>
summary:   Fix 683507 - assertion fired when constructing a Vector with the wrong number of parameters (r=edwsmith)

http://hg.mozilla.org/tamarin-redux/rev/db7dd23cd076
changeset: 6565:c2f81526c576
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 683507: testcase for Vector construction that uses multiple type args which should produce a RTE (r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/c2f81526c576
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Flags: in-testsuite+
Flags: flashplayer-qrb?
Flags: flashplayer-qrb+
You need to log in before you can comment on or make changes to this bug.