Last Comment Bug 683510 - GCLI needs a 'console' command
: GCLI needs a 'console' command
Status: RESOLVED FIXED
[good first bug]
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 12
Assigned To: Berker Peksag [:berkerpeksag]
:
:
Mentors:
Depends on:
Blocks: GCLI-SHIP 715530
  Show dependency treegraph
 
Reported: 2011-08-31 07:48 PDT by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2013-02-11 10:40 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Prototype console/close console/filter commands (1.50 KB, text/plain)
2011-11-11 06:52 PST, Joe Walker [:jwalker] (needinfo me or ping on irc)
no flags Details
'console close' command (1.24 KB, patch)
2011-12-18 07:49 PST, Berker Peksag [:berkerpeksag]
no flags Details | Diff | Splinter Review
'console close' command (1.21 KB, patch)
2011-12-18 08:28 PST, Berker Peksag [:berkerpeksag]
mihai.sucan: review+
Details | Diff | Splinter Review

Description Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-08-31 07:48:55 PDT
This command allows the user to filter, clear and close the web console
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-11-11 06:52:03 PST
Created attachment 573788 [details]
Prototype console/close console/filter commands
Comment 2 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-11-11 06:55:15 PST
There is already a 'console clear' command: https://hg.mozilla.org/integration/fx-team/file/15c2cf2f47f4/browser/devtools/webconsole/GcliCommands.jsm#l99

But we should probably add 'console close' and 'console filter' commands too.
Comment 3 Kevin Dangoor 2011-11-14 11:20:42 PST
what do you think of a command to change the console's position?
Comment 4 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-11-15 01:01:42 PST
(In reply to Kevin Dangoor from comment #3)
> what do you think of a command to change the console's position?

I think we should do it.
Comment 5 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-11-18 09:59:09 PST
Moving GCLI bugs to Developer Tools: Console. Filter on 'baked beans are off'.
Comment 6 Paul Rouget [:paul] 2011-12-02 06:22:49 PST
Joe, we don't use [good first bug] anymore, but [mentor=...][lang=...]. In this case, I think you want to flag your bug [mentor=joe][lang=js].
Comment 7 Berker Peksag [:berkerpeksag] 2011-12-18 07:49:54 PST
Created attachment 582666 [details] [diff] [review]
'console close' command
Comment 8 Berker Peksag [:berkerpeksag] 2011-12-18 08:28:56 PST
Created attachment 582673 [details] [diff] [review]
'console close' command
Comment 9 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-20 02:12:49 PST
Comment on attachment 582673 [details] [diff] [review]
'console close' command

r+ from me, and I'm passing this on to Mihai who should be able to r+ and mark it for landing. Thanks Berker.
Comment 10 Mihai Sucan [:msucan] 2011-12-20 04:26:15 PST
Comment on attachment 582673 [details] [diff] [review]
'console close' command

Review of attachment 582673 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you Berker for your contribution!
Comment 11 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-09 07:50:04 PST
https://tbpl.mozilla.org/?tree=Fx-Team&rev=9ea2996a1f3c
Comment 12 Tim Taubert [:ttaubert] 2012-01-10 14:50:43 PST
https://hg.mozilla.org/mozilla-central/rev/fdab6d891be0

Note You need to log in before you can comment on or make changes to this bug.