Closed Bug 683708 Opened 13 years ago Closed 12 years ago

mmgc: add hooks for telemetry interface with player

Categories

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P3)

defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 602663
Q2 12 - Cyril

People

(Reporter: pnkfelix, Unassigned)

References

Details

Player has its own telemetry subsystem.

MMgc should be instrumented with hooks to interface with it.

The telemetry client API is based on a small set of macros, so we can define our own set of analogous macros that we would call from MMgc.

The macro API is documented on zerowing at:

  [FlashPlayer:Flash Telemetry Information]
  https://zerowing.corp.adobe.com/x/WctlFw#FlashTelemetryInformation-AddingMetricstosourcecode

The link above is what you should look at, but for ease of reference, I am copying semi-expurgated descriptions for the four macros here:

    TELEMETRY_VALUE( _telemetry, _tag, _value)
    Records any single {int, string} value using the string constant _tag

    TELEMETRY_COUNTER( _telemetry, _tag, _value)
    Adds value to a counter on every call.  (Counters are sent and reset
    at semi-periodic points in time left unspecified in this bug ticket.)

    TELEMETRY_TIME( _telemetry, _tag)
    Records the current time in microseconds from start of instance connection.

    TELEMETRY_METHOD( _telemetry, _tag)
    Records the duration of time in microseconds from this macro declaration
    to the point where it goes out of scope.  Only one copy of this may be
    used per scope.

[The above macros all refer to a telemetry object; presumably the AVM versions of the macros will need to work in the presence or absence of such an object; that, or the patch for this ticket will introduce an abstract void* version of such an object.  Its something still to resolve.]

(Ideally all of AVM would be so instrumented, but MMgc is a good place to start.)
Summary: mmgc: add hooks for probing/instrumentation interface with player → mmgc: add hooks for telemetry interface with player
Blocks: 594546
Flags: flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → Q2 12 - Cyril
Considering bugzilla 602663 has landed the telemetry interface in VM, is this bug still valid?
(In reply to Ruchi Lohani from comment #1)
> Considering bugzilla 602663 has landed the telemetry interface in VM, is
> this bug still valid?

Nope, I guess not.

(There is further instrumentation to do within the guts of MMgc itself, but the task of adding such instrumentation was never the goal of this particular ticket.)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.