683721 - add rev4 testers to buildbot configs

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

We need to have Rev 4 builders in our buildbot configs

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Based on last discussion with jhford (admittedly 2 weeks ago now) and also on bug#683718, I believe this should be "rev 4 testers in our buildbot configs".

Let me know if I missed something or if things have changed?

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: buildbot-configs v1

This patch adds the Rev4 mac machines to the talos and unittest configs.  I also remove the magic around the leopard-o.  This was needed because leopard-o and snowleopard-r4 were being caught by the same condition.  Because we want exactly opposite outcomes for leopard-o and snowleopard-r4, I changed the leopard-o behaviour to a simpler, less magical solution.

Instead of trimming off the -o and using the 'leopard' key for looking up slave information, this patch duplicates the 'leopard' under the 'leopard-o' key.  This allows snowleopard-r4 to work.  The goal of the trimming was to have one pool of slaves easily connect to two different platforms/slave_platforms.

When rolling this out, we'll have to update the password.py and BuildSlaves.py files.  I am not sure what we need to do fro that.

Comment 3

[Armen [:armenzg]]

Comment on attachment 562845 [details] [diff] [review]
buildbot-configs v1

Review of attachment 562845 [details] [diff] [review]:
-----------------------------------------------------------------

At first this seems to do what you want but I would like to run dump masters to see the differences on the list of builders.

For BuildSlaves.py you want to modify this:
http://hg.mozilla.org/build/puppet-manifests/file/5fd0b710e52d/modules/buildmaster/templates/BuildSlaves-tests.py.erb

Comment 4

[Armen [:armenzg]]

Comment on attachment 562845 [details] [diff] [review]
buildbot-configs v1

All good. This only adds Rev4 builders without modifying any other.

Feel free to land this at any time. Check that we can see it showing up on tbpl.

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 562845 [details] [diff] [review]
buildbot-configs v1

http://hg.mozilla.org/build/buildbot-configs/rev/0c5e26f82dd4