683857 - No recipient with Simple MAPI

Status: RESOLVED DUPLICATE of bug 393302

(MailNews Core :: Simple MAPI, defect)

Description

[Laurent R]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0.1) Gecko/20100101 Firefox/6.0.1
Build ID: 20110830092941

Steps to reproduce:

Our software uses MS Simple MAPI to initialize new messages. Everything works fine with other mail clients (Outlook Express, Lotus Notes, ...) but with Thunderbird, the recipients list is always empty (whereas the MAPIAddress structure used with MAPISendMail is not).


Actual results:

A new message is created with subject, object, attachements but no recipients.


Expected results:

The recipients specified in the MAPIAddress structure should appear in the new message

Comment 1

[Ludovic Hirlimann [:Usul]]

Our mapi implementation is visible at https://mxr.mozilla.org/comm-central/source/mailnews/mapi/, laurent would you try to make a patch if we helped ?

Comment 2

[Laurent R]

OK. I had a look at the code and I think I understood what doesn't work with the way we feed the MapiRecipDesc structure.
Instead of setting the lpszAddress field to NULL, we set it to an empty string (""). This works fine with other implementations of Simple MAPI like Outlook Express or Lotus Notes but with Thunderbird implementation, when I look at line #424 of mapihook/src/msgMapiHook.cpp, I understand that the lpszName field of the MapiRecipDesc (which is the one we feed with the email address) is not taken into account when the lpszAddress field is not NULL.
I can't change my caller code right now but i will do it later on to feed the structure in a way that this Thunderbird implementation expects.
However, since other Simple MAPI implementations handle our case very well, maybe you could change this code to read lpszName when lpszAddress is either NULL or references an empty string.

Comment 3

[Laurent R]

Finally, I had access to our code and I could check if what I said was right. It is the case : replacing "" by NULL for the lpszAddress field of MapiRecipDesc resolves the problem with Thunderbird and still works with other mail clients (at least with Lotus Notes).
However, I keep thinking that the Thunderbird implementation could be enhanced by assimilating empty string and NULL, like other Simple MAPI implementations do.

Regards

Comment 4

[Ludovic Hirlimann [:Usul]]

Thanks for the analysis. franck , David does this make sense ?

Comment 5

[Frank Wein [:mcsmurf]]

For reference: http://hg.mozilla.org/comm-central/annotate/f52dd4f08220/mailnews/mapi/mapihook/src/msgMapiHook.cpp blame link for line nr. from Comment 2

Comment 6

[David :Bienvenu]

(In reply to Ludovic Hirlimann [:Usul] from comment #4)
> Thanks for the analysis. franck , David does this make sense ?

sorry, missed this the first time - yes, it makes sense and would be fairly simple to fix.

Comment 7

[Ludovic Hirlimann [:Usul]]

Frank would you have some time to make the patch ?

Comment 8

[Ludovic Hirlimann [:Usul]]

Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.

Comment 9

[michael]

Is anyone able to help with this?  I have exactly the same problem with a program we use that was written in Delhi.  The programmer won't fix it and I don't have the ability to modify the cpp file and compile it (if that's even the right terminology).

Comment 10

[bblack]

This problem is currently being solved in bug 393302.