683861 - L10n dep builds broken: config/rules.mk:437: *** config/config.mk needs to be included before using OBJ_SUFFIX. Stop.

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Mark Banner (:standard8)]

Following the recent update to the tag NSPR_4_9_BETA2, it appears the L10n dep builds (and I guess the nightlies) are broken when they try to run the "make" in objdir/nsprpub:

config/rules.mk:437: *** config/config.mk needs to be included before using OBJ_SUFFIX.  Stop.

I suspect the specific bug that caused this is bug 677191.

Full Log: http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n-es-AR/1314839822.1314840085.25457.gz

Comment 1

[Axel Hecht [:Pike]]

Yes, breaks nightlies, too.

Comment 2

[Mike Hommey [:glandium]]

The first question that comes to mind is, why does it run make in objdir/nsprpub ? The second question that comes to mind is what is different in the l10n script running make in objdir/nsprpub that makes it fail while, obviously, running make in objdir/nsprpub doesn't fail on m-c.

One scenario I can think of is the same as bug 682794, but with config.mk being a non updated version, and autoconf.mk being a new one.

Comment 3

[Mike Hommey [:glandium]]

So here is an explanation: in log, mozilla-central is checked out at d772dfb96ba1, configure is run on that, and after that, mozilla-central is updated to an earlier revision, 005bce677a00. I bet the NSPR_4_9_BETA2 landing is between these two.

Comment 4

[Mark Banner (:standard8)]

In today's builds for Thunderbird, this seems to have recovered.

Comment 5

[Edmund Wong (:ewong)]

Encountered this bug today on trunk SeaMonkey build.

Comment 6

[Mark Banner (:standard8)]

Given the age of this bug, and the lack of comments, I think this is probably long ago WFM. We can always file a new bug/reopen if necessary.