Last Comment Bug 683946 - jsapi.cpp hits build warnings (treated as errors) for NativeX64.h: "error: 'nanojit::SavedRegs' defined but not used", "error: 'nanojit::SingleByteStoreRegs' defined but not used"
: jsapi.cpp hits build warnings (treated as errors) for NativeX64.h: "error: 'n...
Status: RESOLVED FIXED
[build_warning]
:
Product: Core Graveyard
Classification: Graveyard
Component: Nanojit (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks: buildwarning
  Show dependency treegraph
 
Reported: 2011-09-01 10:16 PDT by Daniel Holbert [:dholbert]
Modified: 2014-03-17 08:00 PDT (History)
2 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description Daniel Holbert [:dholbert] 2011-09-01 10:16:23 PDT
Quoting a recent red "warning as error" build from mozilla-inbound:
{
jsapi.cpp
cc1plus: warnings being treated as errors
[...]
/builds/slave/m-in-lnx64-dbg-spidermonkey-warnaserrdebug/src/js/src/nanojit/NativeX64.h: At global scope:
/builds/slave/m-in-lnx64-dbg-spidermonkey-warnaserrdebug/src/js/src/nanojit/NativeX64.h:347:31: error: 'nanojit::SavedRegs' defined but not used
/builds/slave/m-in-lnx64-dbg-spidermonkey-warnaserrdebug/src/js/src/nanojit/NativeX64.h:355:31: error: 'nanojit::SingleByteStoreRegs' defined but not used
}
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1314861122.1314861238.19787.gz
mozilla-inbound_linux64-debug_spidermonkey-warnaserrdebug on 2011/09/01 00:12:02

It looks like there are a bunch of static const variables _defined_ (not declared) in this header, NativeX64.h, and those variables apparently trigger warnings for any .cpp files that #include NativeX64.h without using these variables.

Perhaps we should just be _declaring_ these variables in the header, and move their definitions to NativeX64.cpp?  (In fact, that's the only place SingleByteStoreRegs is even referenced, so in that case the variable could move to the .cpp file entirely, if it made sense.)
Comment 1 Nicholas Nethercote [:njn] 2011-12-07 17:13:50 PST
Nanojit has been removed.

Note You need to log in before you can comment on or make changes to this bug.