Page-mod documentation should link to worker's documentation earlier.

RESOLVED FIXED

Status

Add-on SDK
Documentation
P3
normal
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: KWierso, Assigned: canuckistani)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Currently, the first link to worker's documentation is way down in "Mapping workers to tabs", which is below the halfway point in the page.

But 'worker' is first mentioned up near the top in "Communicating With Content Scripts".

I would move the link for worker's docs up to that first mention of 'worker', personally.



If the big "working with content scripts" rewrite will change the page-mod docs, too, feel free to wontfix this.
I just checked, the patch ( or my current modifications to said patch ) for bug 679479 do not edit page-mod.md. This should definitely be a separate bug.
Assignee: nobody → jgriffiths
Status: NEW → ASSIGNED
Created attachment 557640 [details]
Move the link to the worker docs

Patch to move the link to the worker docs to the earliest sensible instance of the word worker. We could move it one line earlier but stylistically I think this placing of the link makes it more find-able.
OS: Windows 7 → All
Priority: -- → P3
Hardware: x86_64 → All
(Reporter)

Updated

6 years ago
Attachment #557640 - Flags: review?(wbamberg)
Comment on attachment 557640 [details]
Move the link to the worker docs

This patch doesn't apply cleanly any more. I've regenerated one that does, and attached it. Shall I just push it? It seems silly to ask for reveiw again, for such a trivial change...
Attachment #557640 - Flags: review?(wbamberg) → review-
Created attachment 650560 [details] [diff] [review]
another patch
Attachment #557640 - Attachment is obsolete: true
Comment on attachment 650560 [details] [diff] [review]
another patch

Review of attachment 650560 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #650560 - Flags: review+

Comment 6

6 years ago
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/98940794970e265960c71657f3d24d87c627a2e7
Fix bug 684011 - Page-mod documentation should link to worker's documentation earlier.; r=@canuckistani

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.