Last Comment Bug 684049 - cairoint.h uses lround in C90 programs
: cairoint.h uses lround in C90 programs
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla9
Assigned To: :Ehsan Akhgari (away Aug 1-5)
Depends on:
  Show dependency treegraph
Reported: 2011-09-01 14:34 PDT by :Ehsan Akhgari (away Aug 1-5)
Modified: 2011-09-02 08:40 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (v1) (951 bytes, patch)
2011-09-01 14:35 PDT, :Ehsan Akhgari (away Aug 1-5)
jmuizelaar: review+
Details | Diff | Splinter Review

Description :Ehsan Akhgari (away Aug 1-5) 2011-09-01 14:34:29 PDT
lround is a function available in C99 programs, but cairo-int.h is using it in C90 programs as well, which causes libxul to fail to link when building in C90 mode.
Comment 1 :Ehsan Akhgari (away Aug 1-5) 2011-09-01 14:35:31 PDT
Created attachment 557650 [details] [diff] [review]
Patch (v1)
Comment 2 Jeff Muizelaar [:jrmuizel] 2011-09-01 14:40:09 PDT
Comment on attachment 557650 [details] [diff] [review]
Patch (v1)

Add a patch to the cairo directory and a note in the README
Comment 3 :Ehsan Akhgari (away Aug 1-5) 2011-09-01 14:47:50 PDT
Comment 4 :Ehsan Akhgari (away Aug 1-5) 2011-09-02 08:40:15 PDT

Note You need to log in before you can comment on or make changes to this bug.