684190 - "about:newaddon" in urlbar instantly closes tab/browser.

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[patrickjdempsey]

User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.20) Gecko/20110803 Firefox/3.6.20
Build ID: 20110803131630

Steps to reproduce:

Type "about:newaddon" in urlbar attempting to show the Install Add-on tab dialog in an attempt to work on the theme style.


Actual results:

Tab instantly closes... if only one tab, browser instantly closes.  No crash report is generated.  If only one tab and browser closes, must delete places.sqlite and sessionstore files in profile to re-open browser.


Expected results:

Display a placeholder  "about:newaddon" page like blank about:sessionrestore page.

Comment 1

[Alice0775 White]

Confirmed on Nightly9.0a1 and Aurora8.0a2.

http://hg.mozilla.org/mozilla-central/rev/d772dfb96ba1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a1) Gecko/20110901 Firefox/9.0a1 ID:20110901030807
and
http://hg.mozilla.org/releases/mozilla-aurora/rev/03b0d42603f8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20100101 Firefox/8.0a2 ID:20110901042012

Comment 2

[[:Aleksej]]

Confirmed on Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110901 Firefox/9.0a1

Comment 3

[Felix Fung (:felix)]

Attachment: "about:newaddon" should not close tab/browser

Summary of Changes:
- If there is no id parameter, show about:blank instead of closing window.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/05a4fd114908

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/05a4fd114908

Comment 6

[Michael Lefevre]

Maybe it's not important, but there's another window.close() a few lines down for if there is an id which isn't valid, so I guess typing "about:newaddon?blah" would still close the tab/window.

Comment 7

[Vlad [QA]]

I have verified this on latest Nightly:
Mozilla/5.0 (Windows NT 6.1; rv:10.0a1) Gecko/20111011 Firefox/10.0a1

and typing "about:newaddon" doesn't close the tab anymore instead it shows a blank tab even though I have new add-ons installed.
This is intended?
Thanks.

Comment 8

[Felix Fung (:felix)]

Yes this is intended.

Comment 9

[Felix Fung (:felix)]

On second thought. This should be improved some more. The expected behavior should be:

If you only have one tab and you direct it to about:newaddon, it should point you to about:blank.
If you have multiple tabs and you direct it to about:newaddon, it should close the tab.

Comment 10

[Dave Townsend [:mossop]]

(In reply to Felix Fung (:felix) from comment #9)
> On second thought. This should be improved some more. The expected behavior
> should be:
> 
> If you only have one tab and you direct it to about:newaddon, it should
> point you to about:blank.
> If you have multiple tabs and you direct it to about:newaddon, it should
> close the tab.

I don't think this is really worth the effort, and I certainly don't want the code in there to be reliant on tabbrowser APIs

Comment 11

[Dão Gottwald [:dao]]

Also, this patch landed, followup patches go in new bugs.

Comment 13

[[:Aleksej]]

Verified on GNU/Linux (comment 7, comment 8) by chaos, vladmaniac and me with at least these builds:
Aurora: Mozilla/5.0 (X11; Linux x86_64; rv:10.0a2) Gecko/20111117 Firefox/10.0a2
Nightly: Mozilla/5.0 (X11; Linux i686; rv:11.0a1) Gecko/20111117 Firefox/11.0a1
Nightly: Mozilla/5.0 (X11; Linux x86_64; rv:11.0a1) Gecko/20111117 Firefox/11.0a1

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

What about a manual test? Do we need one here, because we can't cover it by automation? I would tend to say so.

Comment 15

[Maniac Vlad Florin (:vladmaniac)]

(In reply to Henrik Skupin (:whimboo) from comment #14)
> What about a manual test? Do we need one here, because we can't cover it by
> automation? I would tend to say so.

for FFTs IMO

Comment 16

[:Gavin Sharp [email: [e-mail]]]

There's no use spending time manually testing something that no average user will ever do.