Open Bug 684192 Opened 11 years ago Updated 4 years ago

Update reflectUnsignedInt to match the tests in reflectInt

Categories

(Core :: DOM: Core & HTML, defect, P5)

defect

Tracking

()

People

(Reporter: mounir, Unassigned, Mentored)

References

Details

(Whiteboard: [lang=js])

Attachments

(2 files)

The work that is being done in bug 669578 for reflectInt() is more complet than what was done for reflectUnsignedInt(). As soon as the patch is landed. we should update the later method to match the former.
I'd like to work on this, should be faster to port over the changes than the the first go-around :)
Attached file An attempt to update
It is far from a complete patch. All I did was trim out some code and added in a bit of code. Just wanted to see what making a patch is like in this great community! Please by all means judge and criticize!
Comment on attachment 578348 [details] [diff] [review]
A naive attempt to update.

Ms2ger, could you review that by any chance? :)
Attachment #578348 - Flags: review?(Ms2ger)
Comment on attachment 578348 [details] [diff] [review]
A naive attempt to update.

>diff -r 259d1556c221 content/html/content/test/reflect.js
>--- a/content/html/content/test/reflect.js	Fri Sep 23 01:12:40 2011 +0100
>+++ b/content/html/content/test/reflect.js	Thu Dec 01 11:45:55 2011 -0800
>+	is(element.getAttribute(attr), expectedGetAttributeResult(v), 
>+           element.localName + ".setAttribute(" + attr + ", " + v + "), " + 
>+           element.localName + ".getAttribute(" + attr + ") ");
>+
>+	if(testExponential(v)){
>+	    //TBD: Bug 673820: .setAttribute(exponential) -> incorrect reflection for element[attr]
>+	    todo_is(element[attr], intValue, "Bug 673820: " + element.localName +
>+                    ".setAttribute(" + attr + ", " + v + "), " + 
>+                    element.localName + "[" + attr + "] ");
>+	} else if (v == "why 567 what") {
>+      //TBD: Bug 679672: .setAttribute() is somehow able to parse "why 567 what" into "567"
>+      todo_is(element[attr], intValue, "Bug 679672: " + element.localName +
>+              ".setAttribute(" + attr + ", " + v + "), " +
>+              element.localName + "[" + attr + "] ");
>+    } else if (v == "+42foo") {
>+      //TBD: Bug: Unable to correctly parse "+" character in front of string
>+      todo_is(element[attr], intValue, "Bug: " + element.localName +
>+              ".setAttribute(" + attr + ", " + v + "), " +
>+              element.localName + "[" + attr + "] ");
>+    } else if (v == "0x10FFFF" && defaultValue != 0) {
>+      //TBD: Bug: Integer attributes should parse "0x10FFFF" as 0, but instead incorrectly return defaultValue
>+      todo_is(element[attr], intValue, "Bug: " + element.localName +
>+              ".setAttribute(" + attr + ", " + v + "), " + element.localName +
>+              "[" + attr + "] ");
>+    } else if ((v == "++2") && element[attr] != defaultValue)  {
>+      //TBD: Bug: Should not be able to parse strings with multiple sign characters, should return defaultValue
>+      todo_is(element[attr], intValue, "Bug: " + element.localName +
>+        ".setAttribute(" + attr + ", " + v + "), " + element.localName + "[" + attr + "] ");

These should all be fixed by now.

Please also remove literal tab characters and ask me for review again when those things are fixed.
Attachment #578348 - Flags: review?(Ms2ger) → review-
Whiteboard: [mentor=volkmar] → [mentor=volkmar][lang=js]
Whiteboard: [mentor=volkmar][lang=js] → [mentor=Ms2ger][lang=js]
If no one is working on this, I would like to take the bug forward. Please let me know what steps shall I undertake. Thanks !!
Mentor: Ms2ger
Whiteboard: [mentor=Ms2ger][lang=js] → [lang=js]
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven't been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.