684222 - Simple way to display a backend in a backenderror

Status: VERIFIED FIXED

(Cloud Services :: Server: Core, defect)

Description

[Tarek Ziadé (:tarek)]

When we want to add more details about the backend in a backenderror, we can use 


  BackendError(server='the.server')

This is fine but implies that we know how to get back the server url or ip etc out of the backend. And this can be different depending on the used backend.

I want to introduce two things:

1/ a backend option for backenderror, to pass the backend
2/ a __str__() function every backend should implement, that displays all the unsecured relevant info about the backend (the url, or the ip or anything else relevant)


BackendError will simply dump str(backend)

Comment 1

[Tarek Ziadé (:tarek)]

Attachment: Adds __str__ to ldappool + backend option in BackendError

Comment 2

[Tarek Ziadé (:tarek)]

Attachment: Adds __str__ to ldappool + backend option in BackendError + server=None

Comment 3

[Tarek Ziadé (:tarek)]

https://hg.mozilla.org/services/server-core/rev/17b0641356f5

Comment 4

[James Bonacci [:jbonacci]]

Need QA steps for verification.

Comment 5

[James Bonacci [:jbonacci]]

Verified in code, actually...