The default bug view has changed. See this FAQ.

Quick Filter Read Icon Different From Read Column Icon

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Theme
--
trivial
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Jeff Grossman, Assigned: Paenglab)

Tracking

({polish})

unspecified
Thunderbird 15.0
x86_64
Windows 7
polish
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 557892 [details]
read icon.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a1) Gecko/20110901 Firefox/9.0a1
Build ID: 20110901030807

Steps to reproduce:

The read icon on the quick filter bar and the read icon on the column heading are not the same.



Expected results:

The two icons should be the same.
I suppose that this is for better usability in quickfilter toolbar
Severity: normal → trivial
Component: Mail Window Front End → Theme
Keywords: polish
QA Contact: front-end → theme
Created attachment 621266 [details]
qfb Unread Icon on WinXP / TB12

Actual:

Trivial, but suppose yes. Having two variants of the Unread glasses icon so close to each other (qfb icon vs. msg list column header)looks a bit odd.

On WinXP theme, things are worse: qfb Unread icon is just a small dot (no glasses), which is not easy to understand (see attached screenshot):
- it is the "read" dot (grey and small), not even the "unread" dot (green & bigger)
- the same small grey dot is also in msg list in the spam column for msgs currently not marked as spam

Expected:

Really, for the "Unread" filter button icon on qfb, the glasses would be much more useful/recognizable.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 3

5 years ago
Created attachment 621273 [details] [diff] [review]
patch

Revived the readcol.png icon for the Quick Filter Read button.
Also added a min-width to make the buttons in icon only mode the same width. Removed also the icons's margin-end to show them centered in icon only mode. Added margin-start on button-text to still have a gap to the icons.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #621273 - Flags: ui-review?(bwinton)
Attachment #621273 - Flags: review?(bwinton)
(Assignee)

Comment 4

5 years ago
Created attachment 621274 [details]
patch in action
Comment on attachment 621273 [details] [diff] [review]
patch

So, the changes to the code seem fine, so I'll say r=me, but...

The quickfilter icon still doesn't match the message column icon, so I'm going to say ui-r-.

I think we should make the column header and the QFB both use the filled-in glasses.  (I also see very different quick filter icons than your screenshot shows.  Do you have any personas applied, or anything else that might explain the differences?  I can take a screenshot if you think it'll help.)

Thanks,
Blake.
Attachment #621273 - Flags: ui-review?(bwinton)
Attachment #621273 - Flags: ui-review-
Attachment #621273 - Flags: review?(bwinton)
Attachment #621273 - Flags: review+
(Assignee)

Comment 6

5 years ago
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #5)
> Comment on attachment 621273 [details] [diff] [review]
> 
> The quickfilter icon still doesn't match the message column icon, so I'm
> going to say ui-r-.

The message column icon is a svg to take and match the tree header text color. If we take again the png icon back to the header, we have this color differences again.

> I think we should make the column header and the QFB both use the filled-in
> glasses.  (I also see very different quick filter icons than your screenshot
> shows.  Do you have any personas applied, or anything else that might
> explain the differences?  I can take a screenshot if you think it'll help.)

The patch is only for XP and you are probably testing on Win7. That would explain the difference.

I propose to leave Win7 as it is and add the glasses to XP with this patch (and change the bug to XP). Then we have XP the same like on Linux with the png glasses and the svg column icon.
(Assignee)

Comment 7

5 years ago
Created attachment 622085 [details] [diff] [review]
patch v2

Same patch as before but with col header read icon with 50% opacity filled glasses for Windows and Linux.
Attachment #621273 - Attachment is obsolete: true
Attachment #622085 - Flags: ui-review?(bwinton)
Attachment #622085 - Flags: review?(bwinton)
(Assignee)

Comment 8

5 years ago
Oops, comment should have be: Same patch as before but *added* col header read icon with 50% opacity filled glasses for Windows and Linux.
Comment on attachment 622085 [details] [diff] [review]
patch v2

Okay, I finally got my Windows XP box up and compiling, and I like it.

ui-r=me, and we can carry forward the r=me from the previous patch.

Thanks, and I apologize for taking so long on this patch.
Blake.
Attachment #622085 - Flags: ui-review?(bwinton)
Attachment #622085 - Flags: ui-review+
Attachment #622085 - Flags: review?(bwinton)
Attachment #622085 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/674f21bd3a1d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.