Closed Bug 684318 Opened 10 years ago Closed 10 years ago

IonMonkey: Don't enter Ion if recording traces

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dvander, Assigned: dvander)

References

Details

Attachments

(1 file, 1 obsolete file)

Failing these tests:
    js1_5/Regress/regress-456470.js
    js1_5/Regress/regress-456494.js

Because we execute Ion code while recording traces, which confuses the trace recorder.
Attached patch fix (obsolete) — Splinter Review
We're not going to test with the tracer enabled, so the problem here is just test cases that explicitly enable the tracer. In this case let's just avoid entering Ion code.
Attachment #557913 - Flags: review?(sstangl)
Attachment #557913 - Flags: review?(sstangl) → review+
Attached patch fixSplinter Review
Attachment #557948 - Flags: review?(sstangl)
Comment on attachment 557913 [details] [diff] [review]
fix

Whoops, forgot to comment: the new patch hardcodes the tracer to be off, instead.
Attachment #557913 - Attachment is obsolete: true
Attachment #557948 - Flags: review?(sstangl) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/d03e1ba0d3b5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.