Closed Bug 684418 Opened 9 years ago Closed 8 years ago

Remove a couple of enablePrivilges from the feed previewer's mochitests

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 10

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file)

The patch for bug 648801 runs into a mochitest error that's orthogonal to what the patch in that bug is trying to do: namely enablePrivilege("UniversalBrowserRead") doesn't fully work with the new security wrappers in that bug. However, instead of fixing the wrappers to deal with this case, it's easier and more correct to nuke another use of enablePrivilege here.

We actually get two for the price of one, since I did the wrong file first.
Attached patch PatchSplinter Review
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #558007 - Flags: review?(josh)
Comment on attachment 558007 [details] [diff] [review]
Patch

I feel more comfortable letting Joel approve this.
Attachment #558007 - Flags: review?(josh) → review?(jmaher)
Comment on attachment 558007 [details] [diff] [review]
Patch

Review of attachment 558007 [details] [diff] [review]:
-----------------------------------------------------------------

nothing jumps out at me here.  Is this tested on try server?
Attachment #558007 - Flags: review?(jmaher) → review+
Try run for cd31a18e63f6 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=cd31a18e63f6
Results (out of 30 total builds):
    success: 30
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-cd31a18e63f6
https://hg.mozilla.org/mozilla-central/rev/af81546ce5a2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.