The default bug view has changed. See this FAQ.

Remove a couple of enablePrivilges from the feed previewer's mochitests

RESOLVED FIXED in Firefox 10

Status

()

Firefox
RSS Discovery and Preview
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

unspecified
Firefox 10
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The patch for bug 648801 runs into a mochitest error that's orthogonal to what the patch in that bug is trying to do: namely enablePrivilege("UniversalBrowserRead") doesn't fully work with the new security wrappers in that bug. However, instead of fixing the wrappers to deal with this case, it's easier and more correct to nuke another use of enablePrivilege here.

We actually get two for the price of one, since I did the wrong file first.
(Assignee)

Comment 1

6 years ago
Created attachment 558007 [details] [diff] [review]
Patch
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #558007 - Flags: review?(josh)

Comment 2

6 years ago
Comment on attachment 558007 [details] [diff] [review]
Patch

I feel more comfortable letting Joel approve this.
Attachment #558007 - Flags: review?(josh) → review?(jmaher)
Comment on attachment 558007 [details] [diff] [review]
Patch

Review of attachment 558007 [details] [diff] [review]:
-----------------------------------------------------------------

nothing jumps out at me here.  Is this tested on try server?
Attachment #558007 - Flags: review?(jmaher) → review+
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=cd31a18e63f6

Comment 5

6 years ago
Try run for cd31a18e63f6 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=cd31a18e63f6
Results (out of 30 total builds):
    success: 30
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-cd31a18e63f6
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/af81546ce5a2
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/af81546ce5a2
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Target Milestone: --- → Firefox 10
You need to log in before you can comment on or make changes to this bug.