684418 - Remove a couple of enablePrivilges from the feed previewer's mochitests

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

The patch for bug 648801 runs into a mochitest error that's orthogonal to what the patch in that bug is trying to do: namely enablePrivilege("UniversalBrowserRead") doesn't fully work with the new security wrappers in that bug. However, instead of fixing the wrappers to deal with this case, it's easier and more correct to nuke another use of enablePrivilege here.

We actually get two for the price of one, since I did the wrong file first.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 558007 [details] [diff] [review]
Patch

I feel more comfortable letting Joel approve this.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 558007 [details] [diff] [review]
Patch

Review of attachment 558007 [details] [diff] [review]:
-----------------------------------------------------------------

nothing jumps out at me here.  Is this tested on try server?

Comment 4

[(no longer active)]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=cd31a18e63f6

Comment 5

[Mozilla RelEng Bot]

Try run for cd31a18e63f6 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=cd31a18e63f6
Results (out of 30 total builds):
    success: 30
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-cd31a18e63f6

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af81546ce5a2

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/af81546ce5a2