68442 - Bezilla renders italics as normal characters.

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[vargol]

I've browsed a couple of websites that have italic characters and the HTML looks
correct.
 In BeZilla they are rendered as normal characters. Probably a BeOS specific bug
I'm sure I've seen italics in other versions of Mozilla. (I haven't got any
other versions to hand
at this moment). The URL above is an example URL with lots of italics

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

->[e-mail], who did the last BeOS GFX rewrite, I think (see bug 55450)

Comment 2

[Yannick Koehler]

No more working on Bezilla

Comment 3

[timeless]

reporter: afaik Other is an invalid platform for BeOS. If you were using a 
PowerPC please change to Macintosh.

Comment 4

[Christian "betzi" Hoffmann]

Attachment: fixes bold/italic and underlined text rendering

Comment 5

[Makoto Hamanaka]

The Christian's patch didn't worked for me because I'm using 'Haru' Japanese font, 
which have neither italic nor bold style, Though it worked for Humnst777 system font.
So I tried to implement emulating these styles on the base of Christian's patch.

I noticed that current build ignores font settings of the preferences panel.
I also tried to enable this and it seems working.

I'll attach a patch.

Comment 6

[Makoto Hamanaka]

Attachment: [cvs diff -u] gfx/src/beos/nsFontMetricsBeOS.h nsFontMetricsBeOS.cpp nsRenderingContextBeOS.cpp

Comment 7

[Paul]

It seems as if the macro NS_WITH_SERVICE has been removed.  The line:

      NS_WITH_SERVICE( nsIPref, prefs, kPrefCID, &res );
needs to be changed to:

      nsCOMPtr<nsIPref> prefs = do_GetService( kPrefCID, &res );

Comment 8

[Makoto Hamanaka]

It seems so.
Also, I think we should implement 'text zoom', too.

Comment 9

[Makoto Hamanaka]

I just made a new patch.
Changes from previous patch are:
(1) implemented textzoom (menubar->View->TextSize now works)
(2) added Sync() around on drawing functions of nsRenderingContextBeOS
(3) set clipping region to null when mClipRegion is null in
nsRenderingContextBeOS::UpdateView()
(4) fixed inconsistency in coding style, eliminate tabs.
(5) changeed underline position slightly
This (3) also fixes caret hiding problem and I feel much better in writing some
text in mozilla.
(2) may slows down drawing but fixes some glitches in drawing.

review needed.

Comment 10

[Makoto Hamanaka]

Attachment: [cvs diff -u] gfx/src/beos/nsFontMetricsBeOS.h nsFontMetricsBeOS.cpp nsRenderingContextBeOS.cpp

Comment 11

[Makoto Hamanaka]

Attachment: [cvs diff -uw] gfx/src/beos/nsFontMetricsBeOS.h nsFontMetricsBeOS.cpp nsRenderingContextBeOS.cpp for easier review

Comment 12

[Paul]

Attachment: Made patch to compile again

Fixed the patch to compile again.  Seems to work just fine.  Also includes some
code cleanup for nsRenderingContextBeOS.

Comment 13

[hacker formerly known as [e-mail]]

Comment on attachment 58321 [details] [diff] [review]
Made patch to compile again

r=cls works for me

Comment 14

[hacker formerly known as [e-mail]]

Patch has been checked in.