Created attachment 558045 [details] Tree status message The tree closure hook requires that <span id="treestatus" and <span id="extended-status"> are on the same line. However, despite the warning to do that, the tree was closed yesterday without following this rule, allowing an accidental push to go through. I think it makes more sense to either allow the newline, or treat the existence of a newline as a closed tree (without support for the magic words). Also, the approval needed hook doesn't recognize <span id="tree-status" (note the dash), whereas the closed tree hook does. This seems likely to bite someone at some point as well.
Created attachment 561482 [details] [diff] [review] Patch v1
Hi Ms2ger A few minutes after your commit today the hghooks tree stopped mirroring to the slaves. I see your changes were to the tree close commit hooks but I'm not clear if your commits are related to this issue. [09-21-2011 11:32:34] SERVICE ALERT: hg1.build.scl1;Mercurial mirrorsync;CRITICAL;SOFT;1;SYNC PROBLEMS - 1 of 6 repositories out of sync 2011-09-21 20:28 +0200 Ms2ger - Bug 684460 - Make the tree closure hooks more robust; r=aki default tip
I don't see how that could be in any way related. AFAIK none of the code in the hghooks repo is automatically updated on the hg servers, it has to be explicitly updated. Presumably something went wrong with the mirroring process, and it's just bad luck that it was that commit.