Closed
Bug 684472
Opened 13 years ago
Closed 13 years ago
Reduce QIs in nsPrintingPromptService
Categories
(Core Graveyard :: Embedding: APIs, defect)
Core Graveyard
Embedding: APIs
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
8.78 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
I think you own this...
Attachment #558053 -
Flags: review?(benjamin)
Flags: in-testsuite-
|
||
Comment 1•13 years ago
|
||
Comment on attachment 558053 [details] [diff] [review]
Patch v1
>diff --git a/embedding/components/printingui/src/unixshared/nsPrintingPromptService.cpp b/embedding/components/printingui/src/unixshared/nsPrintingPromptService.cpp
>+ nsCOMPtr<nsIWebProgressListener> myWebProgressListener = this;
>+ myWebProgressListener.forget(webProgressListener);
This is weird. The normal way to do this is NS_ADDREF(*webProgressListener = this);
r=me with that change. I didn't review the OS/2 bits at all, since I just don't care.
Attachment #558053 -
Flags: review?(benjamin) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
I'm no fan of NS_ADDREF, but sure.
http://hg.mozilla.org/mozilla-central/rev/8540ca31ca8f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•