Closed Bug 684472 Opened 10 years ago Closed 10 years ago
Reduce QIs in ns
Printing Prompt Service
I think you own this...
Attachment #558053 - Flags: review?(benjamin)
Comment on attachment 558053 [details] [diff] [review] Patch v1 >diff --git a/embedding/components/printingui/src/unixshared/nsPrintingPromptService.cpp b/embedding/components/printingui/src/unixshared/nsPrintingPromptService.cpp >+ nsCOMPtr<nsIWebProgressListener> myWebProgressListener = this; >+ myWebProgressListener.forget(webProgressListener); This is weird. The normal way to do this is NS_ADDREF(*webProgressListener = this); r=me with that change. I didn't review the OS/2 bits at all, since I just don't care.
Attachment #558053 - Flags: review?(benjamin) → review+
I'm no fan of NS_ADDREF, but sure. http://hg.mozilla.org/mozilla-central/rev/8540ca31ca8f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.