The default bug view has changed. See this FAQ.

crash in nsAbCardProperty::SetPropertyAsAString before trying to use nsDependentCString

RESOLVED FIXED in Thunderbird 18.0

Status

MailNews Core
Address Book
--
critical
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: wsmwk, Assigned: aceman)

Tracking

({crash})

Trunk
Thunderbird 18.0
x86_64
Windows 7
crash
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #684481 +++

crash in nsAbCardProperty::SetPropertyAsAString before trying to use nsDependentCString

bp-009cd991-f43b-45e2-8d7e-ca14b2110831
EXCEPTION_ACCESS_VIOLATION_READ
0x0
0	mozcrt19.dll	strlen	strlen.asm:81
1	xul.dll	nsDependentCString::nsDependentCString	objdir-tb/mozilla/dist/include/nsTDependentString.h:90
2	xul.dll	nsAbCardProperty::SetPropertyAsAString	mailnews/addrbook/src/nsAbCardProperty.cpp:314
3	xul.dll	nsAddrDatabase::InitCardFromRow	mailnews/addrbook/src/nsAddrDatabase.cpp:2473
4	xul.dll	nsAddrDatabase::CreateCard	mailnews/addrbook/src/nsAddrDatabase.cpp:2966
5	xul.dll	nsAddrDatabase::GetCardFromAttribute	mailnews/addrbook/src/nsAddrDatabase.cpp:3161
6	xul.dll	nsAbMDBDirectory::CardForEmailAddress	mailnews/addrbook/src/nsAbMDBDirectory.cpp:1086
I was going to suggest an add-on issue, however, this looks like the column name in the mork file is "".

Not sure if David or Mike have any ideas here, but a starter would be to add a NS_ENSURE_ARG_POINTER to SetPropertyAsString (and related functions in that file) - which we should probably have anyway, as xpcom rules require us to be able to handle null.
(Assignee)

Updated

5 years ago
Assignee: nobody → acelists
(Assignee)

Comment 2

5 years ago
Created attachment 656989 [details] [diff] [review]
patch
Attachment #656989 - Flags: review?(mconley)
Attachment #656989 - Flags: feedback?(mbanner)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Comment on attachment 656989 [details] [diff] [review]
patch

Review of attachment 656989 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, this looks like the right thing to do. Thanks aceman!
Attachment #656989 - Flags: review?(mconley) → review+
Comment on attachment 656989 [details] [diff] [review]
patch

Yep, if we're not getting a name, erroring out is the right thing to do.
Attachment #656989 - Flags: feedback?(mbanner)
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/721cec51e685
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.