684518 - Task view rows get a border after restarting (aero theme not applied)

Status: RESOLVED FIXED

(Calendar :: Tasks, defect)

Description

[Alistair Low]

Attachment: before.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0.1) Gecko/20100101 Firefox/6.0.1
Build ID: 20110830092941

Steps to reproduce:

1. Install Lightning from a clean Thunderbird profile.
2. Hide the Today pane and the task details pane.
3. Add some tasks.
4. Restart the application 3 or 4 times.


Actual results:

A single pixel dotted border appears between columns in the task list table. A larger dotted border appears between the rows.

A Thunderbird update temporarily fixes it but then after a few more restarts the problem re-appears.


Expected results:

The task view should stay as intended, without borders between the rows and columns.

Comment 1

[Alistair Low]

Attachment: Showing borders

Comment 2

[Alistair Low]

I managed to work around this by removing the following lines from \extensions\{e2fda1a4-762b-4020-b5ad-a41df1933103}\chrome\calendar\skin\calendar\calendar-task-view.css:

#calendar-task-tree > .calendar-task-tree > treechildren::-moz-tree-row {
    border-bottom: 1px dotted #AAA;
}

#calendar-task-tree > .calendar-task-tree > treechildren::-moz-tree-cell {
    border-right: 1px dotted #AAA;
}

Comment 3

[Richard Marti (:Paenglab)]

The borders are only a symptom of not correctly loading the aero css files. You see this also on the thick borders or the sidebar header of the today-pane panel.

Philipp would it be okay, when I try a other attempt to activate the aero css files?

Comment 4

[Stefan Sitter [:ssitter]]

So it is related or identical to Bug 668127?

Comment 5

[Richard Marti (:Paenglab)]

(In reply to Stefan Sitter from comment #4)
> So it is related or identical to Bug 668127?

Yes, identical

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Other approach to bind aero files

This is an other approach to bind the aero files. It is like the technique how FX and TB are adding the Aero theme but only for some files. The files are then added with @import to the css styles. The 0 byte files in XP folder are to avoid errors in XP mode.

I'm using this attempt since a longer time and had newer the problem of not loaded aero files as before also whit a lot of testing.

Comment 7

[Richard Marti (:Paenglab)]

A short description how this patch is working.

With defining

% skin win_OS classic/1.0 chrome/calendar/skin/calendar/XP/ os=WINNT osversion<6
% skin win_OS classic/1.0 chrome/calendar/skin/calendar/Aero/ os=WINNT osversion>=6

win_OS is used as a skin resource (I hope this is the right description). Depending of the used OS a directory is assigned to this resource.

Now on a CSS file with @import url(chrome://win_OS/skin/calendar.css) a file with special definitions can be imported. The XP file is zero bytes because no special definitions are needed, but the file exists to prevent a error message of a not existing file. This could be changed to shorten the main file and make it easier to the aero file to not override definitions.

That's all the magic. I'm using this in my themes (and also a lot of other themers) and since this change I haven't seen the not loading of the aero styles. With a default Lightning after some restarts the not loading happens and only deleting startupCache.4.little (naturally with TB not running) reverts to the aero styles.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Other approach to bind aero files v2

Unbitrotted patch

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 578828 [details] [diff] [review]
Other approach to bind aero files v2


>+% skin win_OS classic/1.0 chrome/calendar/skin/calendar/XP/ os=WINNT osversion<6
>+% skin win_OS classic/1.0 chrome/calendar/skin/calendar/Aero/ os=WINNT osversion>=6

I'd prefer to lowercase the platform names, maybe win-classic and win-aero?

Also, win_OS sounds very general and its well possible that someone else will have the same idea. This should rather be "calendar-windows", or "calendar-aero" (although that may be misleading).


Aside from the naming, r=philipp
If you need this on the (now merged) aurora or beta, approval for that and be sure to push asap.

Comment 10

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in

(In reply to Philipp Kewisch [:Fallen] from comment #9)
> Comment on attachment 578828 [details] [diff] [review]
> Other approach to bind aero files v2
> 
> 
> >+% skin win_OS classic/1.0 chrome/calendar/skin/calendar/XP/ os=WINNT osversion<6
> >+% skin win_OS classic/1.0 chrome/calendar/skin/calendar/Aero/ os=WINNT osversion>=6
> 
> I'd prefer to lowercase the platform names, maybe win-classic and win-aero?

Done

> Also, win_OS sounds very general and its well possible that someone else
> will have the same idea. This should rather be "calendar-windows", or
> "calendar-aero" (although that may be misleading).

Done using calendar-windows

> Aside from the naming, r=philipp
> If you need this on the (now merged) aurora or beta, approval for that and
> be sure to push asap.

I'm first pushing to comm-central and wait if everything works. Then I'll push to comm-aurora (because of the Tabs on Top followup patch for calendar).

Comment 11

[Richard Marti (:Paenglab)]

Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/8f98ccdf3d9b>

Comment 12

[Alfred Peters [:infofrommozilla]]

(In reply to Richard Marti [:paenglab] from comment #11)
> Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/8f98ccdf3d9b>

This removes lightning-aero.css but there is still a reference in
calendar/lightning/jar.mn

<http://hg.mozilla.org/comm-central/file/8f98ccdf3d9b/calendar/lightning/jar.mn#l59>

Comment 13

[Philip Chee]

This causes:
http://tinderbox.mozilla.org/showlog.cgi?log=CalendarTrunk/1324580358.1324590934.22916.gz

RuntimeError: File "themes/winstripe/lightning-aero.css" not found in e:\buildbot\comm-central-win32\build\calendar\lightning, e:\buildbot\comm-central-win32\build\objdir-tb\calendar\lightning
make[4]: *** [libs] Error 1
make[3]: *** [libs_tier_app] Error 2
make[2]: *** [tier_app] Error 2
make[1]: Leaving directory `/e/buildbot/comm-central-win32/build/objdir-tb'
make[1]: *** [default] Error 2
make: *** [build] Error 2

Did you actually test your patch before pushing? You do have a try server after all.

Comment 14

[Philip Chee]

Attachment: Build Bustage Fix.

This patch builds locally. Hope this turns the tinderbox green.

Comment 15

[Richard Marti (:Paenglab)]

Philip, thank you for the bustage fix. I'm at work and can't do anything.

Comment 16

[Richard Marti (:Paenglab)]

(In reply to Philip Chee from comment #14)
> Created attachment 584022 [details] [diff] [review]
> Build Bustage Fix.
> 
> This patch builds locally. Hope this turns the tinderbox green.

+% style chrome://lightning/content/messenger-overlay-sidebar.xul chrome://calendar/skin/win-aero/lightning.css os=WINNT osversion>=6

This line isn't needed.

Comment 17

[Philip Chee]

Attachment: Build Bustage Fix v2.0

> +% style chrome://lightning/content/messenger-overlay-sidebar.xul chrome://calendar/skin/win-aero/lightning.css os=WINNT osversion>=6

> This line isn't needed.
Fixed.

Comment 18

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 584024 [details] [diff] [review]
Build Bustage Fix v2.0

r=philipp

Comment 19

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset a6e30fd92350

Comment 20

[Richard Marti (:Paenglab)]

Pushed to comm-aurora: <http://hg.mozilla.org/releases/comm-aurora/rev/5d3111addc24>
and bustage fix also:  <http://hg.mozilla.org/releases/comm-aurora/rev/c9b3e9818b49>