The default bug view has changed. See this FAQ.

Crash [@ LocationSetterGuts]

RESOLVED FIXED in mozilla9

Status

()

Core
XPConnect
P1
critical
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: bz)

Tracking

(Blocks: 1 bug, {crash, regression, testcase})

Trunk
mozilla9
crash, regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox9-)

Details

(crash signature)

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 558106 [details]
testcase

I'm guessing this is a regression from bug 639720.
(Reporter)

Comment 1

6 years ago
Created attachment 558107 [details]
stack trace
Created attachment 558496 [details] [diff] [review]
Restore missing null-check for location setter.
Attachment #558496 - Flags: review?(mrbkap)
Requesting tracking for this crash regression, on the wild chance that we don't get the patch landed before aurora branch.
Assignee: nobody → bzbarsky
tracking-firefox9: --- → ?
Priority: -- → P1
Whiteboard: [need review]

Updated

6 years ago
Attachment #558496 - Flags: review?(mrbkap) → review+
Adding the Windows specific signature so it shows up in crash stats.
Crash Signature: [@ LocationSetterGuts<nsIDOMWindow>] → [@ LocationSetterGuts<nsIDOMWindow>] [@ LocationSetterGuts<nsIDOMDocument> ]
OS: Mac OS X → All
Hardware: x86_64 → All
Whiteboard: [need review] → [need landing]
http://hg.mozilla.org/integration/mozilla-inbound/rev/9d0d13998ebb
Flags: in-testsuite+
Whiteboard: [need landing]
Target Milestone: --- → mozilla9
Backed out - https://tbpl.mozilla.org/?tree=Mozilla-Inbound&usebuildbot=1&rev=d01a282b5a40 should be the clearest rev to see the orange from this set, free from the leak that backout fixed.
Yeah, this caused the orange.  The issue was that we were wrapping the nsIDOMLocation into vp _before_ doing the JS_ValueToString!  I switched the order of those, and things are peachy now.  Pushed http://hg.mozilla.org/integration/mozilla-inbound/rev/575af26e14b8
http://hg.mozilla.org/mozilla-central/rev/575af26e14b8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 9

5 years ago
Landed in 9, not tracking now.
tracking-firefox9: ? → -
You need to log in before you can comment on or make changes to this bug.