Closed Bug 684544 Opened 13 years ago Closed 13 years ago

Crash [@ LocationSetterGuts]

Categories

(Core :: XPConnect, defect, P1)

Product:
Core
Component:
XPConnect
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla9
Tracking Flags:
Tracking Status
firefox9 - ---

People

(Reporter: jruderman, Assigned: bzbarsky)

References

Details

(Keywords: crash, regression, testcase)

Crash Data

Attachments

(3 files)

testcase
260 bytes, text/html
Details
stack trace
7.52 KB, text/plain
Details
Restore missing null-check for location setter.
4.08 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
Attached file testcase — 
I'm guessing this is a regression from bug 639720.
Attached file stack trace — 

    
    

    
  
Requesting tracking for this crash regression, on the wild chance that we don't get the patch landed before aurora branch.
Assignee: nobody → bzbarsky

          tracking-firefox9:
          --- → ?
Priority: -- → P1
Whiteboard: [need review]

        Attachment #558496 -
        Flags: review?(mrbkap) → review+

    
    

    
  
Adding the Windows specific signature so it shows up in crash stats.
Crash Signature: [@ LocationSetterGuts<nsIDOMWindow>] → [@ LocationSetterGuts<nsIDOMWindow>]
[@ LocationSetterGuts<nsIDOMDocument> ]
OS: Mac OS X → All
Hardware: x86_64 → All

    
  
Whiteboard: [need review] → [need landing]

    
    

    
  
http://hg.mozilla.org/integration/mozilla-inbound/rev/9d0d13998ebb
Flags: in-testsuite+
Whiteboard: [need landing]
Target Milestone: --- → mozilla9

    
    

    
  
Backed out - https://tbpl.mozilla.org/?tree=Mozilla-Inbound&usebuildbot=1&rev=d01a282b5a40 should be the clearest rev to see the orange from this set, free from the leak that backout fixed.

    
    

    
  
Yeah, this caused the orange.  The issue was that we were wrapping the nsIDOMLocation into vp _before_ doing the JS_ValueToString!  I switched the order of those, and things are peachy now.  Pushed http://hg.mozilla.org/integration/mozilla-inbound/rev/575af26e14b8

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/575af26e14b8
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

    
    

    
  
Landed in 9, not tracking now.

          tracking-firefox9:
          ? → -

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: