684727 - Don't call into JNI from ExtensionsView.init

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

In an effort to hide any orphaned Android system notifications, Fennec fires code to clear any notifications on startup. This happens all the time, whether we have orphaned notifications or not. This means we call into the Android nsIAlertsService impl and that means calling JNI too.

This patch uses a preference to identify situations where we might have an orphaned notification. We remove the extra code called during startup and removes calling into JNI unless we really need to.

Note: We need to make sure this patch does not regress bug 620975. Bug 620975 was the reason we attempt to always clear the notification.

Comment 1

[Alex Pakhotin (:alexp)]

Comment on attachment 558298 [details] [diff] [review]
patch

Looks like a regression. I've installed AdBlock Plus, when the notification appeared killed the running Fennec process with a task manager. On restart the notification did not hide.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

This patch fixes a missing identifier problem in BrowserStartup.js

Thanks Alex!

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

ADDONS_NOTIFICATION_NAME wasn't defined

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 3

Alex found a case where we don't clear the notification after a crash. I couldn't reproduce, but I think saving the prefs to disk ASAP is probably a good thing.

Comment 5

[Alex Pakhotin (:alexp)]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> Alex found a case where we don't clear the notification after a crash. I
> couldn't reproduce, but I think saving the prefs to disk ASAP is probably a
> good thing.

The latest patch finally works in my case too!
Thank you Mark!

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1ddde977131a

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/1ddde977131a

Comment 8

[Catalin Suciu [:csuciu]]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1