Remove nsIDOMNSHTMLElement

RESOLVED FIXED in mozilla10

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug, {addon-compat, dev-doc-needed})

Trunk
mozilla10
addon-compat, dev-doc-needed
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 558459 [details] [diff] [review]
Patch v1
Attachment #558459 - Flags: review?(peterv)
HTML5 microdata has nsIVariant attributes, which (last I checked) can't be quickstubbed, so I put them on nsIDOMNSHTMLElement.  How do you propose doing this once nsIDOMNSHTMLElement is gone?
(Assignee)

Comment 3

6 years ago
Created attachment 560596 [details] [diff] [review]
Patch v2

David, not sure what the problem is. Not all nsIDOMHTMLElement members are quickstubbed after this patch.
Attachment #558459 - Attachment is obsolete: true
Attachment #558459 - Flags: review?(peterv)
Attachment #560596 - Flags: review?(peterv)

Updated

6 years ago
Keywords: dev-doc-needed
(Assignee)

Comment 4

6 years ago
Peter, ping?
Comment on attachment 560596 [details] [diff] [review]
Patch v2

Review of attachment 560596 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/xpconnect/src/dom_quickstubs.qsconf
@@ +242,5 @@
> +    'nsIDOMHTMLElement.offsetParent',
> +    'nsIDOMHTMLElement.offsetTop',
> +    'nsIDOMHTMLElement.offsetLeft',
> +    'nsIDOMHTMLElement.offsetWidth',
> +    'nsIDOMHTMLElement.offsetHeight',

I'd just keep nsIDOMHTMLElement.*.
Attachment #560596 - Flags: review?(peterv) → review+
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/239503f172f8
https://hg.mozilla.org/comm-central/rev/7a2784430d36
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: addon-compat
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.