Closed
Bug 684821
Opened 12 years ago
Closed 12 years ago
Remove nsIDOMNSHTMLElement
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
(Keywords: addon-compat, dev-doc-needed)
Attachments
(1 file, 1 obsolete file)
82.19 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Flags: in-testsuite-
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #558459 -
Flags: review?(peterv)
Comment 2•12 years ago
|
||
HTML5 microdata has nsIVariant attributes, which (last I checked) can't be quickstubbed, so I put them on nsIDOMNSHTMLElement. How do you propose doing this once nsIDOMNSHTMLElement is gone?
Assignee | ||
Comment 3•12 years ago
|
||
David, not sure what the problem is. Not all nsIDOMHTMLElement members are quickstubbed after this patch.
Attachment #558459 -
Attachment is obsolete: true
Attachment #558459 -
Flags: review?(peterv)
Attachment #560596 -
Flags: review?(peterv)
Keywords: dev-doc-needed
Assignee | ||
Comment 4•12 years ago
|
||
Peter, ping?
Comment 5•12 years ago
|
||
Comment on attachment 560596 [details] [diff] [review] Patch v2 Review of attachment 560596 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/xpconnect/src/dom_quickstubs.qsconf @@ +242,5 @@ > + 'nsIDOMHTMLElement.offsetParent', > + 'nsIDOMHTMLElement.offsetTop', > + 'nsIDOMHTMLElement.offsetLeft', > + 'nsIDOMHTMLElement.offsetWidth', > + 'nsIDOMHTMLElement.offsetHeight', I'd just keep nsIDOMHTMLElement.*.
Attachment #560596 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/239503f172f8 https://hg.mozilla.org/comm-central/rev/7a2784430d36
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: addon-compat
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•