Closed Bug 684821 Opened 12 years ago Closed 12 years ago

Remove nsIDOMNSHTMLElement

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla10

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

(Keywords: addon-compat, dev-doc-needed)

Attachments

(1 file, 1 obsolete file)

Patch v2
82.19 KB, patch
peterv
: review+
Details | Diff | Splinter Review 
      No description provided.
Flags: in-testsuite-
Attached patch Patch v1 (obsolete) — — Splinter Review 

        Attachment #558459 -
        Flags: review?(peterv)

    
    

    
  
HTML5 microdata has nsIVariant attributes, which (last I checked) can't be quickstubbed, so I put them on nsIDOMNSHTMLElement.  How do you propose doing this once nsIDOMNSHTMLElement is gone?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v2
        — 
          — Splinter Review
      

    


  
David, not sure what the problem is. Not all nsIDOMHTMLElement members are quickstubbed after this patch.

        Attachment #558459 -
        Attachment is obsolete: true

        Attachment #558459 -
        Flags: review?(peterv)

        Attachment #560596 -
        Flags: review?(peterv)

    
  
Keywords: dev-doc-needed

    
    

    
  
Peter, ping?

    
    

    
  
Comment on attachment 560596 [details] [diff] [review]
Patch v2

Review of attachment 560596 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/xpconnect/src/dom_quickstubs.qsconf
@@ +242,5 @@
> +    'nsIDOMHTMLElement.offsetParent',
> +    'nsIDOMHTMLElement.offsetTop',
> +    'nsIDOMHTMLElement.offsetLeft',
> +    'nsIDOMHTMLElement.offsetWidth',
> +    'nsIDOMHTMLElement.offsetHeight',

I'd just keep nsIDOMHTMLElement.*.

        Attachment #560596 -
        Flags: review?(peterv) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/239503f172f8
https://hg.mozilla.org/comm-central/rev/7a2784430d36
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: addon-compat
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.