Closed Bug 684821 Opened 9 years ago Closed 9 years ago

Remove nsIDOMNSHTMLElement

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

(Keywords: addon-compat, dev-doc-needed)

Attachments

(1 file, 1 obsolete file)

No description provided.
Flags: in-testsuite-
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #558459 - Flags: review?(peterv)
HTML5 microdata has nsIVariant attributes, which (last I checked) can't be quickstubbed, so I put them on nsIDOMNSHTMLElement.  How do you propose doing this once nsIDOMNSHTMLElement is gone?
Attached patch Patch v2Splinter Review
David, not sure what the problem is. Not all nsIDOMHTMLElement members are quickstubbed after this patch.
Attachment #558459 - Attachment is obsolete: true
Attachment #558459 - Flags: review?(peterv)
Attachment #560596 - Flags: review?(peterv)
Keywords: dev-doc-needed
Peter, ping?
Comment on attachment 560596 [details] [diff] [review]
Patch v2

Review of attachment 560596 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/xpconnect/src/dom_quickstubs.qsconf
@@ +242,5 @@
> +    'nsIDOMHTMLElement.offsetParent',
> +    'nsIDOMHTMLElement.offsetTop',
> +    'nsIDOMHTMLElement.offsetLeft',
> +    'nsIDOMHTMLElement.offsetWidth',
> +    'nsIDOMHTMLElement.offsetHeight',

I'd just keep nsIDOMHTMLElement.*.
Attachment #560596 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/239503f172f8
https://hg.mozilla.org/comm-central/rev/7a2784430d36
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: addon-compat
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.