Fix bundled add-on user counts

RESOLVED FIXED in 6.2.5

Status

defect
P1
normal
RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: fligtar, Assigned: robhudson)

Tracking

Details

Reporter

Description

8 years ago
Now that we sort popularity by most users, add-ons that are bundled with other apps and ping AMO for updates by default are gaming the system unintentionally. For example, the most popular extension (https://addons.mozilla.org/en-US/firefox/extensions/?sort=users) is Microsoft .NET. This is really bad -- we don't want these advertised as the most popular add-ons.

We need a cron that goes through after stats runs every day and:
* Looks for add-ons where (average_daily_users - totaldownloads) is greater than 10,000
* Sets the average_daily_users to totaldownloads

This will ensure these add-ons can never have more users than 100% of the downloads from AMO. This should affect about 40 add-ons.
Reporter

Comment 1

8 years ago
This needs to happen very soon -- .NET is way too prominent.
Target Milestone: --- → 6.2.4
I see at least 67 add-ons that will get hit by this.

mysql> select slug, status s, inactive i, average_daily_users adu, totaldownloads dl from addons where (average_daily_users > totaldownloads) and (average_daily_users - totaldownloads) > 10000 and addontype_id<>9 order by -average_daily_users;
+--------------------------------+---+---+----------+--------+
| slug                           | s | i | adu      | dl     |
+--------------------------------+---+---+----------+--------+
| default                        | 5 | 1 | 78698190 |    250 |
| microsoft-net-framework-assist | 4 | 0 | 11594969 | 472599 |
| test-pilot                     | 4 | 0 |  2629904 | 284504 |
| adobe-dlm                      | 5 | 0 |  1649191 |      0 |
| simbalink                      | 5 | 0 |  1395458 |      1 |
| skype-toolbar-for-firefox      | 5 | 1 |  1382203 |      9 |
| garmin-communicator            | 4 | 0 |  1010349 |  41057 |
| java-console-6001              | 4 | 1 |   738192 | 190421 |
| search-toolbar                 | 5 | 0 |   715126 |      0 |
| english-south-african-language | 4 | 0 |   651124 |  56374 |
| digitalpersona-extension-for-f | 5 | 0 |   647466 |   8955 |
| download-master-toolbar        | 8 | 0 |   541495 |  34647 |
| redpandascnpandaxunlei         | 5 | 0 |   424577 |   9050 |
| global-suggest-speed-up-your-s | 5 | 1 |   379906 | 212814 |
| divx-web-player                | 5 | 1 |   365418 | 116434 |
| righttoclick                   | 4 | 0 |   356747 | 306673 |
| dealio-toolbar-plugin          | 5 | 0 |   326966 |      0 |
| google-gears-portable          | 4 | 0 |   258786 |  45096 |
| connection-manager             | 4 | 0 |   234190 |  11491 |
| preisspion                     | 4 | 0 |   231204 | 157166 |
| iplex-to-allplayer             | 4 | 0 |   218372 | 152670 |
| the-browser-highlighter        | 4 | 0 |   207059 |   6849 |
| hp-product-detection-plugin    | 5 | 0 |   197422 |   2260 |
| ovi-maps-browser-plugin        | 5 | 0 |   191166 |      0 |
| download-master-plugin         | 8 | 0 |   184131 | 117182 |
| seznam-li?ti?ka                | 4 | 0 |   161286 |  11386 |
| elgrancine-stream              | 0 | 0 |   156283 |     70 |
| browser-defender-toolbar       | 5 | 0 |   147282 |  10783 |
| spanish-chile-language-pack    | 5 | 1 |   110859 |   8472 |
| importexporttools              | 8 | 0 |   106099 |  44036 |
| 2yourface                      | 0 | 0 |   104424 |      0 |
| vividas-video-plugin           | 5 | 0 |   100778 |      0 |
| spanish-mexico-language-pack   | 5 | 0 |    85676 |  11484 |
| cctv-player-plugin-for-firefox | 5 | 0 |    82352 |   5772 |
| 35-nem-hivatalos-magyar-nyelvi | 5 | 0 |    77579 |    920 |
| 5019~                          | 5 | 1 |    68464 |      0 |
| download-accelerator-plus-comp | 5 | 0 |    56944 |  14920 |
| hide-bookmarksbar              | 4 | 0 |    55777 |  40792 |
| yahoo??????                    | 5 | 0 |    54152 |    379 |
| yahoo?????                     | 5 | 0 |    53932 |    270 |
| yahoo????                      | 5 | 0 |    53922 |    323 |
| todoanimes-stream              | 0 | 0 |    51541 |     10 |
| ecosia-the-green-search        | 8 | 0 |    49614 |  19351 |
| url-fixer-plus-ru-and-ua       | 4 | 0 |    46517 |  11568 |
| daemon-tools-toolbar           | 0 | 0 |    46157 |   8876 |
| vkhelperplus                   | 5 | 0 |    38435 |      0 |
| portalarium-player             | 5 | 0 |    34419 |   1563 |
| toggle-persona                 | 9 | 0 |    28452 |    367 |
| vkh                            | 5 | 0 |    27573 |      0 |
| sendsms                        | 5 | 0 |    27314 |   6911 |
| test-10824                     | 5 | 1 |    25485 |      1 |
| fb-layouts                     | 0 | 0 |    25335 |   3271 |
| waltershop                     | 5 | 0 |    25162 |      0 |
| eesti-et-keele-pakk            | 4 | 0 |    24971 |   9476 |
| galician-galiza-language-pack  | 5 | 1 |    24700 |    154 |
| firefox-2-saskarnes-latviskoju | 5 | 0 |    24393 |   1843 |
| sinhala-lk-language-pack       | 5 | 0 |    23460 |   3110 |
| telugu-in-language-pack-6930   | 5 | 0 |    23143 |   2773 |
| 1passwd                        | 4 | 1 |    19699 |   3366 |
| ask-chrome-search-engine       | 5 | 0 |    18339 |      0 |
| facebook-emoticon              | 0 | 0 |    16366 |   4100 |
| copy-to-lightning-note-for-fir | 4 | 0 |    15288 |   4335 |
| vkhelper2                      | 5 | 0 |    14522 |      0 |
| scrollbar-anywhere             | 8 | 0 |    14437 |   3253 |
| snapforseniors-toolbar         | 4 | 0 |    13485 |   3347 |
| printingtools                  | 8 | 0 |    13469 |   2414 |
| blockquote-source              | 5 | 0 |    12482 |   2322 |
+--------------------------------+---+---+----------+--------+
67 rows in set (0.05 sec)
Group: client-services-security
Reporter

Comment 3

8 years ago
that's fine
robhudson is all over this!
Assignee: nobody → chudson
Reporter

Comment 5

8 years ago
ADU counts are public now -- this doesn't need to be hidden.
Group: client-services-security
Target Milestone: 6.2.4 → 6.2.5
Assignee

Comment 6

8 years ago
https://github.com/jbalogh/zamboni/commit/c1588538479d9f85f4c1419e1f22c794a1674ace
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.