Open Bug 685027 Opened 13 years ago Updated 2 years ago

Closing last Firefox window doesn't reliably exit the process needs Firefox > Exit

Categories

(Firefox :: General, defect)

6 Branch
x86
Windows 7
defect

Tracking

()

UNCONFIRMED

People

(Reporter: cww, Unassigned)

Details

After Firefox 6, Mayumi reports that if she closes Firefox with the [X], the process doesn't quit and so the next time she tries to start Firefox, she gets a "Firefox is already running is not responding" error.

It seems that she had to do Firefox > Exit and quit Firefox that way before it would work again.  This seems to have been needed only once.

No extensions in profile, did a clean install (deleted the install folder) and it didn't help.
Verified as WFM on:
Mozilla/5.0 (Windows NT 6.1; rv:9.0a1) Gecko/20110914 Firefox/9.0a1
Build ID: 20110914030906

Closed Fx with the 'X' several times. The process quit every time I closed the window.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Closing last Firefox window doesn't reliably exit the process needs Firefox > Exit → Closing last Firefox window takes longer to exit the process from Firefox > Exit
Assignee: nobody → netzen
This is just because it takes longer to close the process out when using the x on the top right instead of File | Exit. 

In either way you close, you will eventually be able to open again.  But it's much much easier and noticeable to get the error if you close from the x. 

I'd like to investigate why.
It seems to be just because we dispatch an NS_XUL_CLOSE message and then we execute a close handler when you hit the x on the top right.  We don't do this when you go to File | Exit or press Ctrl+W.  In those later cases we go right to a destroy.
Just a guess..
Depends on: 705761
Does this happen each time you close the browser this way?  

If so, unless there's some reason your HTTP cache is both 1) corrupted each time you close, and 2) large (which would mean you've surfed quite a lot during each session: simple restart and then close window wouldn't be enough, then this probably isn't bug 705761, is definitely related to cache deletion.

From comment 0 it sounds like this was repeated, and the workaround (Firefox > Exit) makes it unlikely to be 705761, so I'm clearing the dependency for now.
No longer depends on: 705761
> Does this happen each time you close the browser this way?  

Yes 100% reproducible, I'm sure for all users.
So I profiled this on a clean profile and seen that from the time of the last nsWindow destroy call, until global memory is released, it takes about ~200ms whether you press the close button or go to the menu and exit.  It also feels about the same speed.

I think what I was seeing was that I had the Google Reader notifier extension installed.  When this is installed it gives you a little popup window on startup.  If you close your window with the X on the top right corner the process doesn't finish until this notification goes away.  If you exit from the top left it exits right away even before the notification goes away.  

I'm thinking the findings aren't too interesting for us to fix so I'm going to revert this bug back to its original state before I commented on it.
Status: NEW → UNCONFIRMED
Ever confirmed: false
Summary: Closing last Firefox window takes longer to exit the process from Firefox > Exit → Closing last Firefox window doesn't reliably exit the process needs Firefox > Exit
One possible reason for this bug might have been that the window was originally opened as hidden like as in bug Bug 580246.
Assignee: netzen → nobody
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.