Last Comment Bug 685041 - Convert #ifdef DEBUG variables in jsgc to DebugOnly
: Convert #ifdef DEBUG variables in jsgc to DebugOnly
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
-- trivial (vote)
: mozilla9
Assigned To: Terrence Cole [:terrence]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-06 17:25 PDT by Terrence Cole [:terrence]
Modified: 2011-09-08 10:27 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fixes this bug. (5.90 KB, patch)
2011-09-06 17:25 PDT, Terrence Cole [:terrence]
luke: review+
Details | Diff | Splinter Review
Replace some #ifdef DEBUG with DebugOnly in jsgc (5.88 KB, patch)
2011-09-07 08:58 PDT, Terrence Cole [:terrence]
no flags Details | Diff | Splinter Review

Description User image Terrence Cole [:terrence] 2011-09-06 17:25:44 PDT
Created attachment 558681 [details] [diff] [review]
Fixes this bug.

This also adds operator++ and operator-- to DebugOnly to support the two users here.
Comment 1 User image Luke Wagner [:luke] 2011-09-06 17:35:52 PDT
Comment on attachment 558681 [details] [diff] [review]
Fixes this bug.

Cool
Comment 2 User image Terrence Cole [:terrence] 2011-09-07 08:58:08 PDT
Created attachment 558836 [details] [diff] [review]
Replace some #ifdef DEBUG with DebugOnly in jsgc

Add bug number and reviewer to commit info.  Ready for checkin.
Comment 3 User image Daniel Holbert [:dholbert] (vacation, returning 2/27) 2011-09-07 11:41:44 PDT
Landed:
  http://hg.mozilla.org/integration/mozilla-inbound/rev/c7589174b0f0

(For future reference -- it's better to use "Bug 123" instead of "Bug: 123" in your commit messages, as TBPL detects & autolinkifies the former but not the latter)

Note You need to log in before you can comment on or make changes to this bug.