685139 - node.contains(node) returns false per spec and in Gecko, true in other browsers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[bugzilla33]

Attachment: contains.html

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0a1) Gecko/20110907 Firefox/9.0a1
Build ID: 20110907030853

Steps to reproduce:

1. open testcase
2. click TEST button


Actual results:

theSameElem.contains(theSameElem) returns FALSE


Expected results:

theSameElem.contains(theSameElem) should returns TRUE

like: IE9, Chrome 13, Safari 5.1, Opera 11.5, Konqueror 4.5

Comment 1

[Mounir Lamouri (:mounir)]

This is not what the specs require but maybe they should change if all other browsers does it this way?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Requesting tracking to make sure we don't ship something incompatible here if the spec changes in the next few weeks...

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch + tests

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 558794 [details] [diff] [review]
patch + tests

r=me

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/2cbb9f7ffe32

Comment 6

[Eric Shepherd [:sheppy]]

This is documented as implemented, but I've added a note that this is contrary to the specification.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Spec was changed to match implementations a while back.  I've removed the note from the devmo docs.

Comment 8

[Eric Shepherd [:sheppy]]

Thanks bz. :)

Comment 9

[Johnny Stenback (:jst)]

This made 9, not tracking at this point.