If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add tap-hold selection color status to row selection

VERIFIED FIXED in Firefox 9

Status

Fennec Graveyard
General
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: aaronmt, Assigned: sriram)

Tracking

({polish, ux-userfeedback})

Trunk
Firefox 9
All
Android
polish, ux-userfeedback

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Follow-up to bug 660686

One thing missing from this implementation is the tap-hold selection color status on the entire row region. In the stock browser on Gingerbread, this will be orange, and on the Galaxy SII, they default theirs as blue.
(Assignee)

Updated

6 years ago
Assignee: nobody → sriram
(Assignee)

Comment 1

6 years ago
Do we need to have blue on Galaxy SII?
Or, are we defaulting it to the gingerbread's orange?
(Assignee)

Comment 2

6 years ago
Created attachment 558985 [details] [diff] [review]
Patch

This patch changes the row highlight color to orange.
Attachment #558985 - Flags: review?(mark.finkle)
Comment on attachment 558985 [details] [diff] [review]
Patch

Is gingerbread the only theme that supports fulltoggle settings? I thought honeycomb would too.
(Assignee)

Comment 4

6 years ago
Honeycomb also supports fulltoggle. The "tap-hold" is done for gingerbread alone for now.
Honeycomb has bug 682412 to pretty up the settings. This will be done for honeycomb as a part of that bug.
Attachment #558985 - Flags: review?(mark.finkle) → review+
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/fd8e6806a30b
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/fd8e6806a30b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 9
Backed out because bug 660686 was backed out to fix bug 686379:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e864670fad4e
Status: RESOLVED → REOPENED
Keywords: polish, ux-userfeedback
Hardware: ARM → All
Resolution: FIXED → ---
Target Milestone: Firefox 9 → ---
This can re-land with the new patches in bug 660686.
Status: REOPENED → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/94182039abda
Keywords: checkin-needed
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/94182039abda
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 9
(Reporter)

Comment 11

6 years ago
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110919 Firefox/9.0a1 Fennec/9.0a1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.