Closed Bug 685229 Opened 13 years ago Closed 13 years ago

drawingbuffer-static-canvas-test.html crashes debug build

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 681791

People

(Reporter: drs, Unassigned)

References

Details

Attachments

(1 file)

Patch v1.0, drawingbuffer-static-canvas-test.html fix.
1.12 KB, patch
Details | Diff | Splinter Review 
This crash happens when running drawingbuffer-static-canvas-test.html. It seems to crash on context creation, so there's no JS context yet (so I didn't include a backtrace of the JS stack).

This seems to be a regression that appeared somewhere between 2 weeks ago and yesterday.

OUTPUT FROM THE CONSOLE

--- WebGL context created: 0x107ac5800
###!!! ABORT: Invalid texture size when WebGL surface already exists at that size?: 'mCanvasSurface', file /Users/doug/builds/mozilla-central3/gfx/layers/opengl/CanvasLayerOGL.cpp, line 137
mozilla::layers::CanvasLayerOGL::Initialize(mozilla::layers::CanvasLayer::Data const&)+0x00000245 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x01891777]
mozilla::WebGLContext::GetCanvasLayer(nsDisplayListBuilder*, mozilla::layers::CanvasLayer*, mozilla::layers::LayerManager*)+0x000002C3 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x007A1AB3]
nsHTMLCanvasElement::GetCanvasLayer(nsDisplayListBuilder*, mozilla::layers::CanvasLayer*, mozilla::layers::LayerManager*)+0x00000075 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x00857355]
nsHTMLCanvasFrame::BuildLayer(nsDisplayListBuilder*, mozilla::layers::LayerManager*, nsDisplayItem*)+0x00000160 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x00422A50]
nsDisplayCanvas::BuildLayer(nsDisplayListBuilder*, mozilla::layers::LayerManager*, mozilla::FrameLayerBuilder::ContainerParameters const&)+0x00000034 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x0042322E]
mozilla::(anonymous namespace)::ContainerState::ProcessDisplayItems(nsDisplayList const&, mozilla::FrameLayerBuilder::Clip&)+0x00000379 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x002D9F29]
mozilla::(anonymous namespace)::ContainerState::ProcessDisplayItems(nsDisplayList const&, mozilla::FrameLayerBuilder::Clip&)+0x000000B7 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x002D9C67]
mozilla::FrameLayerBuilder::BuildContainerLayerFor(nsDisplayListBuilder*, mozilla::layers::LayerManager*, nsIFrame*, nsDisplayItem*, nsDisplayList const&, mozilla::FrameLayerBuilder::ContainerParameters const&, gfx3DMatrix const*)+0x00000692 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x002DAA9E]
nsDisplayOwnLayer::BuildLayer(nsDisplayListBuilder*, mozilla::layers::LayerManager*, mozilla::FrameLayerBuilder::ContainerParameters const&)+0x00000064 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x00327B58]
mozilla::(anonymous namespace)::ContainerState::ProcessDisplayItems(nsDisplayList const&, mozilla::FrameLayerBuilder::Clip&)+0x00000379 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x002D9F29]
mozilla::(anonymous namespace)::ContainerState::ProcessDisplayItems(nsDisplayList const&, mozilla::FrameLayerBuilder::Clip&)+0x000000B7 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x002D9C67]
mozilla::(anonymous namespace)::ContainerState::ProcessDisplayItems(nsDisplayList const&, mozilla::FrameLayerBuilder::Clip&)+0x000000B7 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x002D9C67]
mozilla::FrameLayerBuilder::BuildContainerLayerFor(nsDisplayListBuilder*, mozilla::layers::LayerManager*, nsIFrame*, nsDisplayItem*, nsDisplayList const&, mozilla::FrameLayerBuilder::ContainerParameters const&, gfx3DMatrix const*)+0x00000692 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x002DAA9E]
nsDisplayList::PaintForFrame(nsDisplayListBuilder*, nsRenderingContext*, nsIFrame*, unsigned int) const+0x00000311 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x0032B75F]
nsDisplayList::PaintRoot(nsDisplayListBuilder*, nsRenderingContext*, unsigned int) const+0x0000003A [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x0032BA7A]
nsLayoutUtils::PaintFrame(nsRenderingContext*, nsIFrame*, nsRegion const&, unsigned int, unsigned int)+0x00000D0E [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x0035B418]
PresShell::Paint(nsIView*, nsIWidget*, nsRegion const&, nsIntRegion const&, int, int)+0x00000260 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x003831E8]
nsViewManager::RenderViews(nsView*, nsIWidget*, nsRegion const&, nsIntRegion const&, int, int)+0x000000B5 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x009F71F3]
nsViewManager::Refresh(nsView*, nsIWidget*, nsIntRegion const&, unsigned int)+0x000001C3 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x009F73D5]
nsViewManager::DispatchEvent(nsGUIEvent*, nsIView*, nsEventStatus*)+0x0000085A [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x009F7FB8]
_ZL11HandleEventP10nsGUIEvent+0x0000006C [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x009F3150]
nsChildView::DispatchEvent(nsGUIEvent*, nsEventStatus&)+0x00000303 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x0146461B]
nsChildView::DispatchWindowEvent(nsGUIEvent&)+0x0000002E [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x0145F412]
-[ChildView drawRect:inContext:]+0x00000472 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x01471163]
-[ChildView drawRect:]+0x00000093 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x01460273]
-[NSView _drawRect:clip:]+0x00000F9B [/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x00054855]
-[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]+0x00000BCC [/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x0005250A]
-[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]+0x000016BD [/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x00052FFB]
-[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]+0x000016BD [/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x00052FFB]
-[NSThemeFrame _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]+0x0000010E [/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x0005123C]
-[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:]+0x00001293 [/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x0004C64A]
-[NSView displayIfNeeded]+0x0000068C [/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x00045093]
_handleWindowNeedsDisplayOrLayoutOrUpdateConstraints+0x00000288 [/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x000447D3]
__CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__+0x00000017 [/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x00063647]
__CFRunLoopDoObservers+0x00000176 [/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x000635A6]
__CFRunLoopRun+0x00000339 [/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x00038889]
CFRunLoopRunSpecific+0x000000E6 [/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x00038216]
RunCurrentEventLoopInMode+0x00000115 [/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox +0x000024FF]
ReceiveNextEventCommon+0x000000B5 [/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox +0x00009B73]
BlockUntilNextEventMatchingListInMode+0x0000003E [/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox +0x00009AAE]
_DPSNextEvent+0x00000293 [/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x00009191]
-[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:]+0x00000087 [/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x00008A95]
-[NSApplication run]+0x000001CF [/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x000053D6]
nsAppShell::Run()+0x0000007A [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x0145107C]
nsAppStartup::Run()+0x0000008C [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x0119F8F8]
XRE_main+0x0000231F [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x0000D3F7]
_ZL7do_mainPKciPPc+0x000003BE [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/firefox-bin +0x00001B66]
main+0x00000212 [/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/firefox-bin +0x00001DCD]
###!!! ABORT: Invalid texture size when WebGL surface already exists at that size?: 'mCanvasSurface', file /Users/doug/builds/mozilla-central3/gfx/layers/opengl/CanvasLayerOGL.cpp, line 137

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000000
0x00000001000d8aab in TouchBadMemory () at /Users/doug/builds/mozilla-central3/memory/mozalloc/mozalloc_abort.cpp:66
66	    gDummyCounter += *p;   // TODO annotation saying we know 

GDB BACKTRACE

#0  0x00000001000d8aab in TouchBadMemory () at /Users/doug/builds/mozilla-central3/memory/mozalloc/mozalloc_abort.cpp:66
#1  0x00000001000d8af6 in mozalloc_abort (msg=0x7fff5fbf9330 "###!!! ABORT: Invalid texture size when WebGL surface already exists at that size?: 'mCanvasSurface', file /Users/doug/builds/mozilla-central3/gfx/layers/opengl/CanvasLayerOGL.cpp, line 137") at /Users/doug/builds/mozilla-central3/memory/mozalloc/mozalloc_abort.cpp:87
#2  0x000000010274e9aa in Abort (aMsg=Could not find the frame base for "Abort(char const*)".
) at /Users/doug/builds/mozilla-central3/xpcom/base/nsDebugImpl.cpp:388
#3  0x000000010274eeeb in NS_DebugBreak_P (aSeverity=3, aStr=0x1030f7728 "Invalid texture size when WebGL surface already exists at that size?", aExpr=0x1030f7603 "mCanvasSurface", aFile=0x1030f7550 "/Users/doug/builds/mozilla-central3/gfx/layers/opengl/CanvasLayerOGL.cpp", aLine=137) at /Users/doug/builds/mozilla-central3/xpcom/base/nsDebugImpl.cpp:345
#4  0x0000000102891777 in mozilla::layers::CanvasLayerOGL::Initialize (this=0x12bb030a0, aData=@0x7fff5fbf97c0) at /Users/doug/builds/mozilla-central3/gfx/layers/opengl/CanvasLayerOGL.cpp:136
#5  0x00000001017a1ab3 in mozilla::WebGLContext::GetCanvasLayer (this=0x11af62750, aBuilder=0x7fff5fbfae30, aOldLayer=0x0, aManager=0x110c77130) at /Users/doug/builds/mozilla-central3/content/canvas/src/WebGLContext.cpp:865
#6  0x0000000101857355 in nsHTMLCanvasElement::GetCanvasLayer (this=0x11af5ee00, aBuilder=0x7fff5fbfae30, aOldLayer=0x0, aManager=0x110c77130) at /Users/doug/builds/mozilla-central3/content/html/content/src/nsHTMLCanvasElement.cpp:743
#7  0x0000000101422a50 in nsHTMLCanvasFrame::BuildLayer (this=0x107b0fe80, aBuilder=0x7fff5fbfae30, aManager=0x110c77130, aItem=0x107b2dfe0) at /Users/doug/builds/mozilla-central3/layout/generic/nsHTMLCanvasFrame.cpp:282
#8  0x000000010142322e in nsDisplayCanvas::BuildLayer (this=0x107b2dfe0, aBuilder=0x7fff5fbfae30, aManager=0x110c77130, aContainerParameters=@0x7fff5fbfa080) at /Users/doug/builds/mozilla-central3/layout/generic/nsHTMLCanvasFrame.cpp:104
#9  0x00000001012d9f29 in mozilla::(anonymous namespace)::ContainerState::ProcessDisplayItems (this=0x7fff5fbfa060, aList=@0x107b2e0a8, aClip=@0x7fff5fbf9d50) at /Users/doug/builds/mozilla-central3/layout/base/FrameLayerBuilder.cpp:1404
#10 0x00000001012d9c67 in mozilla::(anonymous namespace)::ContainerState::ProcessDisplayItems (this=0x7fff5fbfa060, aList=@0x107b2e110, aClip=@0x7fff5fbf9f30) at /Users/doug/builds/mozilla-central3/layout/base/FrameLayerBuilder.cpp:1356
#11 0x00000001012daa9e in mozilla::FrameLayerBuilder::BuildContainerLayerFor (this=0x7fff5fbfae30, aBuilder=0x7fff5fbfae30, aManager=0x110c77130, aContainerFrame=0x107315ca0, aContainerItem=0x107b2e0e0, aChildren=@0x107b2e110, aParameters=@0x7fff5fbfa8c0, aTransform=0x0) at /Users/doug/builds/mozilla-central3/layout/base/FrameLayerBuilder.cpp:1825
#12 0x0000000101327b58 in nsDisplayOwnLayer::BuildLayer (this=0x107b2e0e0, aBuilder=0x7fff5fbfae30, aManager=0x110c77130, aContainerParameters=@0x7fff5fbfa8c0) at /Users/doug/builds/mozilla-central3/layout/base/nsDisplayList.cpp:1801
#13 0x00000001012d9f29 in mozilla::(anonymous namespace)::ContainerState::ProcessDisplayItems (this=0x7fff5fbfa8a0, aList=@0x107b2e168, aClip=@0x7fff5fbfa410) at /Users/doug/builds/mozilla-central3/layout/base/FrameLayerBuilder.cpp:1404
#14 0x00000001012d9c67 in mozilla::(anonymous namespace)::ContainerState::ProcessDisplayItems (this=0x7fff5fbfa8a0, aList=@0x107b2e378, aClip=@0x7fff5fbfa590) at /Users/doug/builds/mozilla-central3/layout/base/FrameLayerBuilder.cpp:1356
#15 0x00000001012d9c67 in mozilla::(anonymous namespace)::ContainerState::ProcessDisplayItems (this=0x7fff5fbfa8a0, aList=@0x7fff5fbfac70, aClip=@0x7fff5fbfa770) at /Users/doug/builds/mozilla-central3/layout/base/FrameLayerBuilder.cpp:1356
#16 0x00000001012daa9e in mozilla::FrameLayerBuilder::BuildContainerLayerFor (this=0x7fff5fbfae30, aBuilder=0x7fff5fbfae30, aManager=0x110c77130, aContainerFrame=0x1089d7df0, aContainerItem=0x0, aChildren=@0x7fff5fbfac70, aParameters=@0x7fff5fbfaa90, aTransform=0x0) at /Users/doug/builds/mozilla-central3/layout/base/FrameLayerBuilder.cpp:1825
#17 0x000000010132b75f in nsDisplayList::PaintForFrame (this=0x7fff5fbfac70, aBuilder=0x7fff5fbfae30, aCtx=0x0, aForFrame=0x1089d7df0, aFlags=5) at /Users/doug/builds/mozilla-central3/layout/base/nsDisplayList.cpp:598
#18 0x000000010132ba7a in nsDisplayList::PaintRoot (this=0x7fff5fbfac70, aBuilder=0x7fff5fbfae30, aCtx=0x0, aFlags=5) at /Users/doug/builds/mozilla-central3/layout/base/nsDisplayList.cpp:538
#19 0x000000010135b418 in nsLayoutUtils::PaintFrame (aRenderingContext=0x0, aFrame=0x1089d7df0, aDirtyRegion=@0x7fff5fbfb5b0, aBackstop=4294967295, aFlags=260) at /Users/doug/builds/mozilla-central3/layout/base/nsLayoutUtils.cpp:1697
#20 0x00000001013831e8 in PresShell::Paint (this=0x10e26c3b0, aViewToPaint=0x10e2253b0, aWidgetToPaint=0x10e26b760, aDirtyRegion=@0x7fff5fbfb5b0, aIntDirtyRegion=@0x7fff5fbfba40, aPaintDefaultBackground=0, aWillSendDidPaint=0) at /Users/doug/builds/mozilla-central3/layout/base/nsPresShell.cpp:6194
#21 0x00000001019f71f3 in nsViewManager::RenderViews (this=0x10e224510, aView=0x10e2253b0, aWidget=0x10e26b760, aRegion=@0x7fff5fbfb5b0, aIntRegion=@0x7fff5fbfba40, aPaintDefaultBackground=0, aWillSendDidPaint=0) at /Users/doug/builds/mozilla-central3/view/src/nsViewManager.cpp:416
#22 0x00000001019f73d5 in nsViewManager::Refresh (this=0x10e224510, aView=0x10e2253b0, aWidget=0x10e26b760, aRegion=@0x7fff5fbfba40, aUpdateFlags=1) at /Users/doug/builds/mozilla-central3/view/src/nsViewManager.cpp:391
#23 0x00000001019f7fb8 in nsViewManager::DispatchEvent (this=0x10e224510, aEvent=0x7fff5fbfb9f0, aView=0x10e2253b0, aStatus=0x7fff5fbfb7fc) at /Users/doug/builds/mozilla-central3/view/src/nsViewManager.cpp:894
#24 0x00000001019f3150 in HandleEvent (aEvent=0x7fff5fbfb9f0) at /Users/doug/builds/mozilla-central3/view/src/nsView.cpp:159
#25 0x000000010246461b in nsChildView::DispatchEvent (this=0x10e26b760, event=0x7fff5fbfb9f0, aStatus=@0x7fff5fbfb91c) at /Users/doug/builds/mozilla-central3/widget/src/cocoa/nsChildView.mm:1516
#26 0x000000010245f412 in nsChildView::DispatchWindowEvent (this=0x10e26b760, event=@0x7fff5fbfb9f0) at /Users/doug/builds/mozilla-central3/widget/src/cocoa/nsChildView.mm:1526
#27 0x0000000102471163 in -[ChildView drawRect:inContext:] (self=0x10e26b8a0, _cmd=0x1030b6448, aRect={origin = {x = 0, y = 0}, size = {width = 1680, height = 915}}, aContext=0x10e62a170) at /Users/doug/builds/mozilla-central3/widget/src/cocoa/nsChildView.mm:2558
#28 0x0000000102460273 in -[ChildView drawRect:] (self=0x10e26b8a0, _cmd=0x7fff8d674cf0, aRect={origin = {x = 0, y = 0}, size = {width = 1680, height = 915}}) at /Users/doug/builds/mozilla-central3/widget/src/cocoa/nsChildView.mm:2464
#29 0x00007fff8cd30855 in -[NSView _drawRect:clip:] ()
#30 0x00007fff8cd2e50a in -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] ()
#31 0x00007fff8cd2effb in -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] ()
#32 0x00007fff8cd2effb in -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] ()
#33 0x00007fff8cd2d23c in -[NSThemeFrame _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] ()
#34 0x00007fff8cd2864a in -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] ()
#35 0x00007fff8cd21093 in -[NSView displayIfNeeded] ()
#36 0x00007fff8cd207d3 in _handleWindowNeedsDisplayOrLayoutOrUpdateConstraints ()
#37 0x00007fff8f14f647 in __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ ()
#38 0x00007fff8f14f5a6 in __CFRunLoopDoObservers ()
#39 0x00007fff8f124889 in __CFRunLoopRun ()
#40 0x00007fff8f124216 in CFRunLoopRunSpecific ()
#41 0x00007fff9478e4ff in RunCurrentEventLoopInMode ()
#42 0x00007fff94795b73 in ReceiveNextEventCommon ()
#43 0x00007fff94795aae in BlockUntilNextEventMatchingListInMode ()
#44 0x00007fff8cce5191 in _DPSNextEvent ()
#45 0x00007fff8cce4a95 in -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] ()
#46 0x00007fff8cce13d6 in -[NSApplication run] ()
#47 0x000000010245107c in nsAppShell::Run (this=0x100149c90) at /Users/doug/builds/mozilla-central3/widget/src/cocoa/nsAppShell.mm:771
#48 0x000000010219f8f8 in nsAppStartup::Run (this=0x10017c2c0) at /Users/doug/builds/mozilla-central3/toolkit/components/startup/nsAppStartup.cpp:224
#49 0x000000010100d3f7 in XRE_main (argc=5, argv=0x7fff5fbffb40, aAppData=0x1001281d0) at /Users/doug/builds/mozilla-central3/toolkit/xre/nsAppRunner.cpp:3557
#50 0x0000000100001b66 in do_main (exePath=0x7fff5fbff710 "/Users/doug/builds/obj/dist/NightlyDebug.app/Contents/MacOS/libxpcom.dylib", argc=5, argv=0x7fff5fbffb40) at /Users/doug/builds/mozilla-central3/browser/app/nsBrowserApp.cpp:198
#51 0x0000000100001dcd in main (argc=5, argv=0x7fff5fbffb40) at /Users/doug/builds/mozilla-central3/browser/app/nsBrowserApp.cpp:281
Removed an assert that seemed to be crashing this test. Without it, this test and the rest of the mochitests run fine.
Attachment #558897 - Flags: review?(matt.woodrow)
I'd like to know more about why this is happening.

That assert should only ever be hit if the requested size is greater than GL's max texture size. WebGL also requires a texture, so how did it manage to allocate a backing buffer of this size?

What is the size being passed in to CanvasLayerOGL::Initialize, and how is the WebGL object handing this size?
(In reply to Matt Woodrow (:mattwoodrow) from comment #2)

The script here tries to create/resize a WebGL canvas of size 64k x 64k. The max texture size on his machine is 16k. For sure WebGL context creation/resizing didn't succeed. Maybe though the WebGLContext code (WebGLContext::SetDimensions) fails to properly report this failure. Can you please have a look at it and tell me if there's something more it should be doing:

http://hg.mozilla.org/mozilla-central/file/2cbb9f7ffe32/content/canvas/src/WebGLContext.cpp#l510

When it fails, it actually doesn't do anything else than return NS_ERROR_FAILURE:

http://hg.mozilla.org/mozilla-central/file/2cbb9f7ffe32/content/canvas/src/WebGLContext.cpp#l679
SetDimensions shouldn't modify mWidth/mHeight if context creation fails, so I can't see how thse would ever be set to an invalid size.

Can someone please step through SetDimensions() and GetCanvasLayer() to see how the invalid size gets set, and how we manage to get a valid gl context to pass into layers.

I feel like we should be returning nsnull from GetCanvasLayer() rather than creating a layer that can't draw anything.
I think we figured it today on Mac: GLContext::ResizeOffscreen is virtual and reimplemented in GLContextCGL, so we never do the size check in GLContext::ResizeOffscreenFBO, calling IsOffscreenSizeAllowed...

Need to check all GLContextProvider's for similar issues.
Depends on: 681791
Isn't this fixed already by some recent change?
Yes, I think so. I'll track it down.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
Heh, silly me. Past-me correctly marked this as blocked by the same bug I wasted time looking up. :)
Attachment #558897 - Flags: review?(matt.woodrow)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: