685554 - Set OS_TARGET to WINNT when crosscompiling on mingw

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

The build system expects OS_TARGET to be WINNT for Windows, but in my setup (crosscompiling on Linux with mingw-w64), it's set to ${target_os}, which is "mingw32". The attached patch fixes it the way we do it for other OSes.

I've found it when bug 677501 landed on m-c, so my builds will be broken without this patch once 677501 will land again.

Comment 1

[Mike Hommey [:glandium] (high latency)]

Comment on attachment 559170 [details] [diff] [review]
fix v1.0

Review of attachment 559170 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +1279,5 @@
>      OS_RELEASE=
>      case "${target_os}" in
>          linux*)       OS_ARCH=Linux OS_TARGET=Linux ;;
>          kfreebsd*-gnu) OS_ARCH=GNU_kFreeBSD OS_TARGET=GNU_kFreeBSD ;;
> +        gnu*)         OS_ARCH=GNU OS_TARGET=WINNT ;;

That's the entry for GNU, as in GNU/Hurd. I doubt it works.

Comment 2

[Jacek Caban]

Attachment: fix v1.1

Oh, I'm terribly sorry about that! It's a copy&paste typo when copying between trees to prepare the patch. Here is the right version, sorry.

Comment 3

[Jacek Caban]

Thanks for he review.

http://hg.mozilla.org/integration/mozilla-inbound/rev/4ec6e53436e6

Comment 4

[Justin Wood (:Callek)]

(In reply to Jacek Caban from comment #3)
> Thanks for he review.
> 
> http://hg.mozilla.org/integration/mozilla-inbound/rev/4ec6e53436e6

landed in m-c