Last Comment Bug 685554 - Set OS_TARGET to WINNT when crosscompiling on mingw
: Set OS_TARGET to WINNT when crosscompiling on mingw
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Windows 7
-- normal (vote)
: mozilla9
Assigned To: Jacek Caban
: Gregory Szorc [:gps] (away until 2017-03-20)
Depends on:
Blocks: 677501
  Show dependency treegraph
Reported: 2011-09-08 08:32 PDT by Jacek Caban
Modified: 2011-09-10 08:35 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix v1.0 (1.73 KB, patch)
2011-09-08 08:32 PDT, Jacek Caban
mh+mozilla: review-
Details | Diff | Splinter Review
fix v1.1 (1.81 KB, patch)
2011-09-08 08:43 PDT, Jacek Caban
mh+mozilla: review+
Details | Diff | Splinter Review

Description User image Jacek Caban 2011-09-08 08:32:45 PDT
Created attachment 559170 [details] [diff] [review]
fix v1.0

The build system expects OS_TARGET to be WINNT for Windows, but in my setup (crosscompiling on Linux with mingw-w64), it's set to ${target_os}, which is "mingw32". The attached patch fixes it the way we do it for other OSes.

I've found it when bug 677501 landed on m-c, so my builds will be broken without this patch once 677501 will land again.
Comment 1 User image Mike Hommey [:glandium] 2011-09-08 08:36:23 PDT
Comment on attachment 559170 [details] [diff] [review]
fix v1.0

Review of attachment 559170 [details] [diff] [review]:

@@ +1279,5 @@
>      OS_RELEASE=
>      case "${target_os}" in
>          linux*)       OS_ARCH=Linux OS_TARGET=Linux ;;
>          kfreebsd*-gnu) OS_ARCH=GNU_kFreeBSD OS_TARGET=GNU_kFreeBSD ;;
> +        gnu*)         OS_ARCH=GNU OS_TARGET=WINNT ;;

That's the entry for GNU, as in GNU/Hurd. I doubt it works.
Comment 2 User image Jacek Caban 2011-09-08 08:43:35 PDT
Created attachment 559172 [details] [diff] [review]
fix v1.1

Oh, I'm terribly sorry about that! It's a copy&paste typo when copying between trees to prepare the patch. Here is the right version, sorry.
Comment 3 User image Jacek Caban 2011-09-09 06:18:28 PDT
Thanks for he review.
Comment 4 User image Justin Wood (:Callek) [away until Feb 27] 2011-09-09 22:51:06 PDT
(In reply to Jacek Caban from comment #3)
> Thanks for he review.

landed in m-c

Note You need to log in before you can comment on or make changes to this bug.