Closed Bug 685554 Opened 8 years ago Closed 8 years ago

Set OS_TARGET to WINNT when crosscompiling on mingw

Categories

(Firefox Build System :: General, defect)

x86_64
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla9

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch fix v1.0 (obsolete) — Splinter Review
The build system expects OS_TARGET to be WINNT for Windows, but in my setup (crosscompiling on Linux with mingw-w64), it's set to ${target_os}, which is "mingw32". The attached patch fixes it the way we do it for other OSes.

I've found it when bug 677501 landed on m-c, so my builds will be broken without this patch once 677501 will land again.
Attachment #559170 - Flags: review?(mh+mozilla)
Comment on attachment 559170 [details] [diff] [review]
fix v1.0

Review of attachment 559170 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +1279,5 @@
>      OS_RELEASE=
>      case "${target_os}" in
>          linux*)       OS_ARCH=Linux OS_TARGET=Linux ;;
>          kfreebsd*-gnu) OS_ARCH=GNU_kFreeBSD OS_TARGET=GNU_kFreeBSD ;;
> +        gnu*)         OS_ARCH=GNU OS_TARGET=WINNT ;;

That's the entry for GNU, as in GNU/Hurd. I doubt it works.
Attachment #559170 - Flags: review?(mh+mozilla) → review-
Attached patch fix v1.1Splinter Review
Oh, I'm terribly sorry about that! It's a copy&paste typo when copying between trees to prepare the patch. Here is the right version, sorry.
Attachment #559170 - Attachment is obsolete: true
Attachment #559172 - Flags: review?(mh+mozilla)
Attachment #559172 - Flags: review?(mh+mozilla) → review+
Thanks for he review.

http://hg.mozilla.org/integration/mozilla-inbound/rev/4ec6e53436e6
Whiteboard: [inbound]
(In reply to Jacek Caban from comment #3)
> Thanks for he review.
> 
> http://hg.mozilla.org/integration/mozilla-inbound/rev/4ec6e53436e6

landed in m-c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.