685555 - python::virtualenv can only be used once per node

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P5)

Description

[Chris AtLee [:catlee]]

if you've got multiple classes that each want to instantiate a virtualenv, you run into this:

err: Could not retrieve catalog from remote server: Error 400 on SERVER: Duplicate definition: Python::Package_dir_file[pip-0.8.2.tar.gz] is already defined in file /etc/puppet/modules/python/manifests/virtualenv.pp at line 146; cannot redefine at /etc/puppet/modules/python/manifests/virtualenv.pp:146 on node buildbot-master10.build.sjc1.mozilla.com

If you factor out python::package_dir_file into its own class, you then run into:

err: Could not retrieve catalog from remote server: Error 400 on SERVER: Duplicate definition: Python::Package[buildbot==0.8.4-pre-moz1] is already defined in file /etc/puppet/modules/python/manifests/virtualenv.pp at line 170; cannot redefine at /etc/puppet/modules/python/manifests/virtualenv.pp:170 on node buildbot-master10.build.sjc1.mozilla.com

filing in relops per dustin on irc.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

There was some miscommunication on which bug should be filed with relops - this is definitely a releng bug.

I didn't see a way to fix the second bug without regular expression support or other features not available in 0.24.8.

Comment 2

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Found in triage.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

This was fixed long ago in PuppetAgain.