Closed Bug 685578 Opened 13 years ago Closed 13 years ago

Send review information to more people

Categories

(support.mozilla.org :: Knowledge Base Software, task, P1)

Tracking

(Not tracked)

VERIFIED FIXED
2011-11-15

People

(Reporter: atopal, Assigned: timw)

Details

Currently only the person asking for review gets an optional message when the article is approved or rejected. Since often the person asking for review bases his revision on an older not approved revision by someone else the notifications fall short.

We should send the message at review time to everyone who has contributed to the article since the last approved revision. With this the message becomes a general comment on the approval/rejection of a revision.

For personal messages there is still the option to send a private message.
Taken from bug 641514. The text should be changed to:

Singular:
"(Optional) Leave a message to the contributor:
Recipient: Scoobidiver"

Plural:
"(Optional) Leave a message to the contributors:
Recipients: Scoobidiver, AliceWyman, Verdi"
It should read, "Leave a message for [Name of contributor]." or "Leave a message for [Name] and [Name]." or "Leave a message for [Name], [Name] and [Name]."
Shouldn't we mention that those people contributed to previous revisions that lead to the current one?

But in any case, this can move forward by Verdi's wording.
OS: Mac OS X → All
Priority: -- → P3
Hardware: x86 → All
Target Milestone: 2011Q3 → 2011Q4
Priority: P3 → P1
Assignee: nobody → timw
So what email text should go to the previous revision authors?
The current copy going to approved or deferred revisions is like.
=====
Your revision has been {reviewed/approved}.

{username} has reviewed your revision to the document
Troubleshooting extensions and themes.

Message from the reviewer:

{message}

To view the history of this document, click the following
link, or paste it into your browser's location bar:

https://support-local.allizom.org/en-US/kb/Troubleshooting%20extensions%20a=
nd%20themes/history
=====

What should be send to the earlier rejected, or possible skipped, revisions?
Can we continue to send the current message to the person who's revision was approved and send this message to the authors of all the other revisions since the last approval?

=====

A revision you contributed to has been {reviewed/approved}.

{username} has {reviewed/approved} a revision to the document {name of document}.

Message from the reviewer:

{message}

To view the history of this document, click the following
link, or paste it into your browser's location bar:

{document url}

=====
pushed https://github.com/jsocol/kitsune/commit/643003777f7e542159e7d86c70d5cd02e2765355
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: 2011Q4 → 2011-11-15
Verified single/multiple reviewer approval message included all people who edited article since last approval, verified email message is correct.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.